| Message ID | 20200429074201.100924-1-borntraeger@de.ibm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] s390x/kvm: help valgrind in several places | expand |
On 29.04.20 09:42, Christian Borntraeger wrote: > We need some little help in the code to reduce the valgrind noise. > This patch does this with some designated initializers for the cpu > model features and subfunctions. > > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com> > --- > target/s390x/kvm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c > index 69881a0da0..f2f75d2a57 100644 > --- a/target/s390x/kvm.c > +++ b/target/s390x/kvm.c > @@ -2165,7 +2165,7 @@ int kvm_arch_msi_data_to_gsi(uint32_t data) > > static int query_cpu_subfunc(S390FeatBitmap features) > { > - struct kvm_s390_vm_cpu_subfunc prop; > + struct kvm_s390_vm_cpu_subfunc prop = {}; > struct kvm_device_attr attr = { > .group = KVM_S390_VM_CPU_MODEL, > .attr = KVM_S390_VM_CPU_MACHINE_SUBFUNC, > @@ -2292,7 +2292,7 @@ static int kvm_to_feat[][2] = { > > static int query_cpu_feat(S390FeatBitmap features) > { > - struct kvm_s390_vm_cpu_feat prop; > + struct kvm_s390_vm_cpu_feat prop = {}; > struct kvm_device_attr attr = { > .group = KVM_S390_VM_CPU_MODEL, > .attr = KVM_S390_VM_CPU_MACHINE_FEAT, > Reviewed-by: David Hildenbrand <david@redhat.com>
On Wed, 29 Apr 2020 03:42:01 -0400 Christian Borntraeger <borntraeger@de.ibm.com> wrote: > We need some little help in the code to reduce the valgrind noise. > This patch does this with some designated initializers for the cpu > model features and subfunctions. > > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com> > --- > target/s390x/kvm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Thanks, applied.
diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c index 69881a0da0..f2f75d2a57 100644 --- a/target/s390x/kvm.c +++ b/target/s390x/kvm.c @@ -2165,7 +2165,7 @@ int kvm_arch_msi_data_to_gsi(uint32_t data) static int query_cpu_subfunc(S390FeatBitmap features) { - struct kvm_s390_vm_cpu_subfunc prop; + struct kvm_s390_vm_cpu_subfunc prop = {}; struct kvm_device_attr attr = { .group = KVM_S390_VM_CPU_MODEL, .attr = KVM_S390_VM_CPU_MACHINE_SUBFUNC, @@ -2292,7 +2292,7 @@ static int kvm_to_feat[][2] = { static int query_cpu_feat(S390FeatBitmap features) { - struct kvm_s390_vm_cpu_feat prop; + struct kvm_s390_vm_cpu_feat prop = {}; struct kvm_device_attr attr = { .group = KVM_S390_VM_CPU_MODEL, .attr = KVM_S390_VM_CPU_MACHINE_FEAT,