diff mbox series

[PULL,8/9] migration/ram: fix use after free of local_err

Message ID 20200325131632.311034-9-dgilbert@redhat.com
State New
Headers show
Series [PULL,1/9] hmp-cmd: fix a missing_break warning | expand

Commit Message

Dr. David Alan Gilbert March 25, 2020, 1:16 p.m. UTC
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

local_err is used again in migration_bitmap_sync_precopy() after
precopy_notify(), so we must zero it. Otherwise try to set
non-NULL local_err will crash.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200324153630.11882-6-vsementsov@virtuozzo.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
 migration/ram.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series


diff --git a/migration/ram.c b/migration/ram.c
index c12cfdbe26..04f13feb2e 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -980,6 +980,7 @@  static void migration_bitmap_sync_precopy(RAMState *rs)
     if (precopy_notify(PRECOPY_NOTIFY_BEFORE_BITMAP_SYNC, &local_err)) {
+        local_err = NULL;