From patchwork Mon Mar 23 16:15:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 1260127 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ovsw7vOH; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48mKLk2jpdz9sR4 for ; Tue, 24 Mar 2020 03:18:38 +1100 (AEDT) Received: from localhost ([::1]:36582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGPme-0004jD-80 for incoming@patchwork.ozlabs.org; Mon, 23 Mar 2020 12:18:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35368) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGPjb-0000wa-Bm for qemu-devel@nongnu.org; Mon, 23 Mar 2020 12:15:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGPja-0002Sm-43 for qemu-devel@nongnu.org; Mon, 23 Mar 2020 12:15:27 -0400 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:38651) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jGPjZ-0002Sb-UZ for qemu-devel@nongnu.org; Mon, 23 Mar 2020 12:15:26 -0400 Received: by mail-wm1-x342.google.com with SMTP id l20so119861wmi.3 for ; Mon, 23 Mar 2020 09:15:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8P3sGDqi30dQIBWbHsRxQdWnqMEvDzwadX4cKsMTRfY=; b=ovsw7vOHGD5shxJ0DRvENojIpEzGgZBYCTE1rxOd2eRPgq3mSZ7QhuJPmYghFHBjVn 1+YXOP9w0NnZaXHmDviOj3rz37h3VPC8rEVCC8VuqhRXX9rLQMsD+eJQirWSbHRW1fgn hOr1FLoCtMbjplKnyrKLbLvyxSNBJULGylYFnsq4Vr9j8Col46UcWNGnqocKKAVJmSet 6YxRgRDqgahYX9sWAUvmqt2CmSALpcHaSN/5UfPUliwoUBscE/mHN4XVJ0VO94IOHIVh BYTNBY0p3z20iGu4z5521mg79jCBhNwAfayokkpOFn8cSGlm4nXzeY1weP5PCnHVq5Ck GNaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8P3sGDqi30dQIBWbHsRxQdWnqMEvDzwadX4cKsMTRfY=; b=tfuCnbKW/4wTRTqm9bDURTaL6CR8Pw8yShNOt01bzn1iEviKWi01eeZlzvYRCiw8Zy tKs7/6Fx9NLhuWOqL0+E5Cw7CC+4AN6SvbB/8VSIvsxujTe2f7DyA6l3masEAtA6AW9J KopELP6toOGYPOP94v2hncstKJ8vQ5AVqor7uNub406HyulHSxgJM+JTCsCr/AbMtJEe 70f1yE2/+1BEbS0nbmm3tRNQzPaF7oIMqG/+oMd7QwEJjKWA9aIhnCKaeBNOC3fC+Uir mefbgazskcWEiTNFl6ngbB/c4QJ+uKd0B6BhL+jm7v63Ye4HluI23BlpZPy7D3IoU7yO 6TVA== X-Gm-Message-State: ANhLgQ23RkUEtCECI0oNWpBmaRFivPucegkGks2Umj9l5qVJ2C8Fl49U 6t1gj4rG1EYR9rgapJ1PaWKPLw== X-Google-Smtp-Source: ADFU+vsQHgpKM1jaKhc/J8UomdFBd0g4fTNMI8xSUSs4byCOwFCderP7fmxwsE5rhOomr2Ul7Gj9Ag== X-Received: by 2002:a05:600c:2193:: with SMTP id e19mr17151wme.142.1584980124816; Mon, 23 Mar 2020 09:15:24 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id s15sm25633956wrr.45.2020.03.23.09.15.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2020 09:15:17 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id CEFF11FF92; Mon, 23 Mar 2020 16:15:15 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 06/11] configure: disable MTTCG for MIPS guests Date: Mon, 23 Mar 2020 16:15:09 +0000 Message-Id: <20200323161514.23952-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200323161514.23952-1-alex.bennee@linaro.org> References: <20200323161514.23952-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::342 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Markovic , Aleksandar Rikalo , =?utf-8?q?Alex_Benn=C3=A9e?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Aurelien Jarno Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" While debugging check-acceptance failures I found an instability in the mips64el test case. Briefly the test case: retry.py -n 100 -c -- ./mips64el-softmmu/qemu-system-mips64el \ -display none -vga none -serial mon:stdio \ -machine malta -kernel ./vmlinux-4.7.0-rc1.I6400 \ -cpu I6400 -smp 8 -vga std \ -append "printk.time=0 clocksource=GIC console=tty0 console=ttyS0 panic=-1" \ --no-reboot Reports about a 9% failure rate: Results summary: 0: 91 times (91.00%), avg time 5.547 (0.45 varience/0.67 deviation) -6: 9 times (9.00%), avg time 3.394 (0.02 varience/0.13 deviation) Ran command 100 times, 91 passes When re-run with "--accel tcg,thread=single" the instability goes away. Results summary: 0: 100 times (100.00%), avg time 17.318 (249.76 varience/15.80 deviation) Ran command 100 times, 100 passes Which seems to indicate there is some aspect of the MIPS MTTCG fixes that has been missed. Ideally we would fix that but I'm afraid I don't have time to investigate and am not super familiar with the architecture anyway. In lieu of someone tracking down the failure lets disable it for now. Signed-off-by: Alex Bennée Acked-by: Philippe Mathieu-Daudé Cc: Aleksandar Markovic Cc: Aurelien Jarno Cc: Aleksandar Rikalo Reviewed-by: Philippe Mathieu-Daudé Acked-by: Richard Henderson Reviewed-by: Aleksandar Markovic Reviewed-by: Aleksandar Markovic --- v2 - only drop mip64le --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 4f12cd01777..a83c6450840 100755 --- a/configure +++ b/configure @@ -7885,7 +7885,7 @@ case "$target_name" in TARGET_SYSTBL_ABI=n32 ;; mips64|mips64el) - mttcg="yes" + mttcg="no" TARGET_ARCH=mips64 TARGET_BASE_ARCH=mips echo "TARGET_ABI_MIPSN64=y" >> $config_target_mak