| Message ID | 20200323161514.23952-7-alex.bennee@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | testing/next | expand |
On 3/23/20 5:15 PM, Alex Bennée wrote: > While debugging check-acceptance failures I found an instability in > the mips64el test case. Briefly the test case: > > retry.py -n 100 -c -- ./mips64el-softmmu/qemu-system-mips64el \ > -display none -vga none -serial mon:stdio \ > -machine malta -kernel ./vmlinux-4.7.0-rc1.I6400 \ > -cpu I6400 -smp 8 -vga std \ > -append "printk.time=0 clocksource=GIC console=tty0 console=ttyS0 panic=-1" \ > --no-reboot > > Reports about a 9% failure rate: > > Results summary: > 0: 91 times (91.00%), avg time 5.547 (0.45 varience/0.67 deviation) > -6: 9 times (9.00%), avg time 3.394 (0.02 varience/0.13 deviation) > Ran command 100 times, 91 passes > > When re-run with "--accel tcg,thread=single" the instability goes > away. > > Results summary: > 0: 100 times (100.00%), avg time 17.318 (249.76 varience/15.80 deviation) > Ran command 100 times, 100 passes > > Which seems to indicate there is some aspect of the MIPS MTTCG fixes > that has been missed. Ideally we would fix that but I'm afraid I don't > have time to investigate and am not super familiar with the > architecture anyway. In lieu of someone tracking down the failure lets > disable it for now. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > Acked-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > Cc: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > Cc: Aurelien Jarno <aurelien@aurel32.net> > Cc: Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com> > > --- > v2 > - only drop mip64le Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 4f12cd01777..a83c6450840 100755 > --- a/configure > +++ b/configure > @@ -7885,7 +7885,7 @@ case "$target_name" in > TARGET_SYSTBL_ABI=n32 > ;; > mips64|mips64el) > - mttcg="yes" > + mttcg="no" > TARGET_ARCH=mips64 > TARGET_BASE_ARCH=mips > echo "TARGET_ABI_MIPSN64=y" >> $config_target_mak >
On 3/23/20 9:15 AM, Alex Bennée wrote: > While debugging check-acceptance failures I found an instability in > the mips64el test case. Briefly the test case: > > retry.py -n 100 -c -- ./mips64el-softmmu/qemu-system-mips64el \ > -display none -vga none -serial mon:stdio \ > -machine malta -kernel ./vmlinux-4.7.0-rc1.I6400 \ > -cpu I6400 -smp 8 -vga std \ > -append "printk.time=0 clocksource=GIC console=tty0 console=ttyS0 panic=-1" \ > --no-reboot > > Reports about a 9% failure rate: > > Results summary: > 0: 91 times (91.00%), avg time 5.547 (0.45 varience/0.67 deviation) > -6: 9 times (9.00%), avg time 3.394 (0.02 varience/0.13 deviation) > Ran command 100 times, 91 passes > > When re-run with "--accel tcg,thread=single" the instability goes > away. > > Results summary: > 0: 100 times (100.00%), avg time 17.318 (249.76 varience/15.80 deviation) > Ran command 100 times, 100 passes > > Which seems to indicate there is some aspect of the MIPS MTTCG fixes > that has been missed. Ideally we would fix that but I'm afraid I don't > have time to investigate and am not super familiar with the > architecture anyway. In lieu of someone tracking down the failure lets > disable it for now. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > Acked-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > Cc: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > Cc: Aurelien Jarno <aurelien@aurel32.net> > Cc: Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com> Acked-by: Richard Henderson <richard.henderson@linaro.org> r~
20:17 Pon, 23.03.2020. Richard Henderson <richard.henderson@linaro.org> је написао/ла: > > On 3/23/20 9:15 AM, Alex Bennée wrote: > > While debugging check-acceptance failures I found an instability in > > the mips64el test case. Briefly the test case: > > > > retry.py -n 100 -c -- ./mips64el-softmmu/qemu-system-mips64el \ > > -display none -vga none -serial mon:stdio \ > > -machine malta -kernel ./vmlinux-4.7.0-rc1.I6400 \ > > -cpu I6400 -smp 8 -vga std \ > > -append "printk.time=0 clocksource=GIC console=tty0 console=ttyS0 panic=-1" \ > > --no-reboot > > > > Reports about a 9% failure rate: > > > > Results summary: > > 0: 91 times (91.00%), avg time 5.547 (0.45 varience/0.67 deviation) > > -6: 9 times (9.00%), avg time 3.394 (0.02 varience/0.13 deviation) > > Ran command 100 times, 91 passes > > > > When re-run with "--accel tcg,thread=single" the instability goes > > away. > > > > Results summary: > > 0: 100 times (100.00%), avg time 17.318 (249.76 varience/15.80 deviation) > > Ran command 100 times, 100 passes > > > > Which seems to indicate there is some aspect of the MIPS MTTCG fixes > > that has been missed. Ideally we would fix that but I'm afraid I don't > > have time to investigate and am not super familiar with the > > architecture anyway. In lieu of someone tracking down the failure lets > > disable it for now. > > > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > > Acked-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > > Cc: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > > Cc: Aurelien Jarno <aurelien@aurel32.net> > > Cc: Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com> > > Acked-by: Richard Henderson <richard.henderson@linaro.org> > Reviewed-by: Aleksandar Markovic <aleksandar.qem u.devel@gmail.com> But, Alex, I expect this patch will go through your queue, not MIPS queue (unless you told me otherwise). Thanks, Aleksandar > > r~
12:53 Sre, 25.03.2020. Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> је написао/ла: > > 20:17 Pon, 23.03.2020. Richard Henderson <richard.henderson@linaro.org> је написао/ла: > > > > On 3/23/20 9:15 AM, Alex Bennée wrote: > > > While debugging check-acceptance failures I found an instability in > > > the mips64el test case. Briefly the test case: > > > > > > retry.py -n 100 -c -- ./mips64el-softmmu/qemu-system-mips64el \ > > > -display none -vga none -serial mon:stdio \ > > > -machine malta -kernel ./vmlinux-4.7.0-rc1.I6400 \ > > > -cpu I6400 -smp 8 -vga std \ > > > -append "printk.time=0 clocksource=GIC console=tty0 console=ttyS0 panic=-1" \ > > > --no-reboot > > > > > > Reports about a 9% failure rate: > > > > > > Results summary: > > > 0: 91 times (91.00%), avg time 5.547 (0.45 varience/0.67 deviation) > > > -6: 9 times (9.00%), avg time 3.394 (0.02 varience/0.13 deviation) > > > Ran command 100 times, 91 passes > > > > > > When re-run with "--accel tcg,thread=single" the instability goes > > > away. > > > > > > Results summary: > > > 0: 100 times (100.00%), avg time 17.318 (249.76 varience/15.80 deviation) > > > Ran command 100 times, 100 passes > > > > > > Which seems to indicate there is some aspect of the MIPS MTTCG fixes > > > that has been missed. Ideally we would fix that but I'm afraid I don't > > > have time to investigate and am not super familiar with the > > > architecture anyway. In lieu of someone tracking down the failure lets > > > disable it for now. > > > > > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > > > Acked-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > > > Cc: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > > > Cc: Aurelien Jarno <aurelien@aurel32.net> > > > Cc: Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com> > > > > Acked-by: Richard Henderson <richard.henderson@linaro.org> > > > > Reviewed-by: Aleksandar Markovic <aleksandar.qem u.devel@gmail.com> > Some trouble with text fi mating - it should be: Reviewed-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> Sorry about that. > But, Alex, I expect this patch will go through your queue, not MIPS queue (unless you told me otherwise). > > Thanks, > Aleksandar > > > > > r~
Yes I'll put it through mine. On Wed, 25 Mar 2020, 10:53 Aleksandar Markovic, < aleksandar.qemu.devel@gmail.com> wrote: > 20:17 Pon, 23.03.2020. Richard Henderson <richard.henderson@linaro.org> > је написао/ла: > > > > On 3/23/20 9:15 AM, Alex Bennée wrote: > > > While debugging check-acceptance failures I found an instability in > > > the mips64el test case. Briefly the test case: > > > > > > retry.py -n 100 -c -- ./mips64el-softmmu/qemu-system-mips64el \ > > > -display none -vga none -serial mon:stdio \ > > > -machine malta -kernel ./vmlinux-4.7.0-rc1.I6400 \ > > > -cpu I6400 -smp 8 -vga std \ > > > -append "printk.time=0 clocksource=GIC console=tty0 console=ttyS0 > panic=-1" \ > > > --no-reboot > > > > > > Reports about a 9% failure rate: > > > > > > Results summary: > > > 0: 91 times (91.00%), avg time 5.547 (0.45 varience/0.67 deviation) > > > -6: 9 times (9.00%), avg time 3.394 (0.02 varience/0.13 deviation) > > > Ran command 100 times, 91 passes > > > > > > When re-run with "--accel tcg,thread=single" the instability goes > > > away. > > > > > > Results summary: > > > 0: 100 times (100.00%), avg time 17.318 (249.76 varience/15.80 > deviation) > > > Ran command 100 times, 100 passes > > > > > > Which seems to indicate there is some aspect of the MIPS MTTCG fixes > > > that has been missed. Ideally we would fix that but I'm afraid I don't > > > have time to investigate and am not super familiar with the > > > architecture anyway. In lieu of someone tracking down the failure lets > > > disable it for now. > > > > > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > > > Acked-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > > > Cc: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > > > Cc: Aurelien Jarno <aurelien@aurel32.net> > > > Cc: Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com> > > > > Acked-by: Richard Henderson <richard.henderson@linaro.org> > > > > Reviewed-by: Aleksandar Markovic <aleksandar.qem u.devel@gmail.com> > > But, Alex, I expect this patch will go through your queue, not MIPS queue > (unless you told me otherwise). > > Thanks, > Aleksandar > > > > > r~ >
diff --git a/configure b/configure index 4f12cd01777..a83c6450840 100755 --- a/configure +++ b/configure @@ -7885,7 +7885,7 @@ case "$target_name" in TARGET_SYSTBL_ABI=n32 ;; mips64|mips64el) - mttcg="yes" + mttcg="no" TARGET_ARCH=mips64 TARGET_BASE_ARCH=mips echo "TARGET_ABI_MIPSN64=y" >> $config_target_mak
While debugging check-acceptance failures I found an instability in the mips64el test case. Briefly the test case: retry.py -n 100 -c -- ./mips64el-softmmu/qemu-system-mips64el \ -display none -vga none -serial mon:stdio \ -machine malta -kernel ./vmlinux-4.7.0-rc1.I6400 \ -cpu I6400 -smp 8 -vga std \ -append "printk.time=0 clocksource=GIC console=tty0 console=ttyS0 panic=-1" \ --no-reboot Reports about a 9% failure rate: Results summary: 0: 91 times (91.00%), avg time 5.547 (0.45 varience/0.67 deviation) -6: 9 times (9.00%), avg time 3.394 (0.02 varience/0.13 deviation) Ran command 100 times, 91 passes When re-run with "--accel tcg,thread=single" the instability goes away. Results summary: 0: 100 times (100.00%), avg time 17.318 (249.76 varience/15.80 deviation) Ran command 100 times, 100 passes Which seems to indicate there is some aspect of the MIPS MTTCG fixes that has been missed. Ideally we would fix that but I'm afraid I don't have time to investigate and am not super familiar with the architecture anyway. In lieu of someone tracking down the failure lets disable it for now. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Acked-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Cc: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> Cc: Aurelien Jarno <aurelien@aurel32.net> Cc: Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com> --- v2 - only drop mip64le --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)