| Message ID | 20200321144110.5010-12-philmd@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | misc: Trivial static code analyzer fixes | expand |
Le 21/03/2020 à 15:41, Philippe Mathieu-Daudé a écrit : > Fix warning reported by Clang static code analyzer: > > CC hw/scsi/esp-pci.o > hw/scsi/esp-pci.c:198:9: warning: Value stored to 'size' is never read > size = 4; > ^ ~ > > Reported-by: Clang Static Analyzer > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > hw/scsi/esp-pci.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-pci.c > index d5a1f9e017..2e6cc07d4e 100644 > --- a/hw/scsi/esp-pci.c > +++ b/hw/scsi/esp-pci.c > @@ -195,7 +195,6 @@ static void esp_pci_io_write(void *opaque, hwaddr addr, > val <<= shift; > val |= current & ~(mask << shift); > addr &= ~3; > - size = 4; > } > > if (addr < 0x40) { > This one has already been reported. I would prefer an assert(), see my comment: https://patchew.org/QEMU/20200302130715.29440-1-kuhn.chenqun@huawei.com/20200302130715.29440-6-kuhn.chenqun@huawei.com/ Thanks, Laurent
diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-pci.c index d5a1f9e017..2e6cc07d4e 100644 --- a/hw/scsi/esp-pci.c +++ b/hw/scsi/esp-pci.c @@ -195,7 +195,6 @@ static void esp_pci_io_write(void *opaque, hwaddr addr, val <<= shift; val |= current & ~(mask << shift); addr &= ~3; - size = 4; } if (addr < 0x40) {
Fix warning reported by Clang static code analyzer: CC hw/scsi/esp-pci.o hw/scsi/esp-pci.c:198:9: warning: Value stored to 'size' is never read size = 4; ^ ~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- hw/scsi/esp-pci.c | 1 - 1 file changed, 1 deletion(-)