| Message ID | 20200313160215.28155-1-linux@roeck-us.net |
|---|---|
| State | New |
| Headers | show |
| Series | hw/arm/pxa2xx: Do not wire up OHCI for PXA255 | expand |
On Fri, 13 Mar 2020 at 16:02, Guenter Roeck <linux@roeck-us.net> wrote: > > PXA255 does not support a USB OHCI controller, so don't wire it up. > > Signed-off-by: Guenter Roeck <linux@roeck-us.net> > --- > hw/arm/pxa2xx.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/hw/arm/pxa2xx.c b/hw/arm/pxa2xx.c > index 56a36202d7..336c9bad4a 100644 > --- a/hw/arm/pxa2xx.c > +++ b/hw/arm/pxa2xx.c > @@ -2290,9 +2290,6 @@ PXA2xxState *pxa255_init(MemoryRegion *address_space, unsigned int sdram_size) > s->ssp[i] = (SSIBus *)qdev_get_child_bus(dev, "ssi"); > } > > - sysbus_create_simple("sysbus-ohci", 0x4c000000, > - qdev_get_gpio_in(s->pic, PXA2XX_PIC_USBH1)); > - > s->pcmcia[0] = pxa2xx_pcmcia_init(address_space, 0x20000000); > s->pcmcia[1] = pxa2xx_pcmcia_init(address_space, 0x30000000); > How did you notice this bug? Was it just reading the code? thanks -- PMM
On 3/16/20 8:35 AM, Peter Maydell wrote: > On Fri, 13 Mar 2020 at 16:02, Guenter Roeck <linux@roeck-us.net> wrote: >> >> PXA255 does not support a USB OHCI controller, so don't wire it up. >> >> Signed-off-by: Guenter Roeck <linux@roeck-us.net> >> --- >> hw/arm/pxa2xx.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/hw/arm/pxa2xx.c b/hw/arm/pxa2xx.c >> index 56a36202d7..336c9bad4a 100644 >> --- a/hw/arm/pxa2xx.c >> +++ b/hw/arm/pxa2xx.c >> @@ -2290,9 +2290,6 @@ PXA2xxState *pxa255_init(MemoryRegion *address_space, unsigned int sdram_size) >> s->ssp[i] = (SSIBus *)qdev_get_child_bus(dev, "ssi"); >> } >> >> - sysbus_create_simple("sysbus-ohci", 0x4c000000, >> - qdev_get_gpio_in(s->pic, PXA2XX_PIC_USBH1)); >> - >> s->pcmcia[0] = pxa2xx_pcmcia_init(address_space, 0x20000000); >> s->pcmcia[1] = pxa2xx_pcmcia_init(address_space, 0x30000000); >> > > How did you notice this bug? Was it just reading the code? > I found that it was wired up and I tried to enable it from Linux, which failed. After that, I dug up the chip manual and realized that the pxa255 hardware does not support it. Guenter
On Fri, 13 Mar 2020 at 16:02, Guenter Roeck <linux@roeck-us.net> wrote: > > PXA255 does not support a USB OHCI controller, so don't wire it up. > > Signed-off-by: Guenter Roeck <linux@roeck-us.net> > --- > hw/arm/pxa2xx.c | 3 --- > 1 file changed, 3 deletions(-) > Applied to target-arm.next, thanks. -- PMM
diff --git a/hw/arm/pxa2xx.c b/hw/arm/pxa2xx.c index 56a36202d7..336c9bad4a 100644 --- a/hw/arm/pxa2xx.c +++ b/hw/arm/pxa2xx.c @@ -2290,9 +2290,6 @@ PXA2xxState *pxa255_init(MemoryRegion *address_space, unsigned int sdram_size) s->ssp[i] = (SSIBus *)qdev_get_child_bus(dev, "ssi"); } - sysbus_create_simple("sysbus-ohci", 0x4c000000, - qdev_get_gpio_in(s->pic, PXA2XX_PIC_USBH1)); - s->pcmcia[0] = pxa2xx_pcmcia_init(address_space, 0x20000000); s->pcmcia[1] = pxa2xx_pcmcia_init(address_space, 0x30000000);
PXA255 does not support a USB OHCI controller, so don't wire it up. Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- hw/arm/pxa2xx.c | 3 --- 1 file changed, 3 deletions(-)