diff mbox series

[RFC,qemu,3/6] mirror: add check for bitmap-mode without bitmap

Message ID 20200218100740.2228521-4-f.gruenbichler@proxmox.com
State New
Headers show
Series mirror: implement incremental and bitmap modes | expand

Commit Message

Fabian Grünbichler Feb. 18, 2020, 10:07 a.m. UTC 
as one without the other does not make much sense with the current set
of modes.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
 blockdev.c | 3 +++
 1 file changed, 3 insertions(+)
diff mbox series

Patch

diff --git a/blockdev.c b/blockdev.c
index 8f7b7ba5eb..23df9f76ba 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3868,6 +3868,9 @@  static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs,
         if (bdrv_dirty_bitmap_check(bitmap, BDRV_BITMAP_ALLOW_RO, errp)) {
             return;
         }
+    } else if (has_bitmap_mode) {
+        error_setg(errp, "Cannot specify bitmap sync mode without a bitmap");
+        return;
     }
 
     if (has_replaces) {