| Message ID | 20200215162337.5809-1-f4bug@amsat.org |
|---|---|
| State | New |
| Headers | show |
| Series | configure: Avoid compiling system tools on user build by default | expand |
On 2/15/20 8:23 AM, Philippe Mathieu-Daudé wrote: > User-mode does not need the sytem tools. Do not build them by > default if user specified --disable-system. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > configure | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
5:23 PM Sub, 15.02.2020. Philippe Mathieu-Daudé <f4bug@amsat.org> је написао/ла: > > User-mode does not need the sytem tools. Do not build them by > default if user specified --disable-system. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > configure | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > It would be nice if somebody comes up with more detailed analysis on what is built for --disable-system, but in fact not needed at all. How does your change affect the size of the executable? > diff --git a/configure b/configure > index 16f94cd96b..557ca4bd04 100755 > --- a/configure > +++ b/configure > @@ -455,7 +455,7 @@ guest_agent_ntddscsi="no" > guest_agent_msi="" > vss_win32_sdk="" > win_sdk="no" > -want_tools="yes" > +want_tools="" > libiscsi="" > libnfs="" > coroutine="" > @@ -2199,6 +2199,15 @@ else > echo big/little test failed > fi > > +########################################## > +# system tools > +if test "$want_tools" != "yes" && test "$softmmu" = "no"; then > + want_tools=no > +fi > +if test -z "$want_tools"; then > + want_tools=yes > +fi > + > ########################################## > # cocoa implies not SDL or GTK > # (the cocoa UI code currently assumes it is always the active UI > -- > 2.21.1 > >
On Sun, Feb 16, 2020 at 8:27 PM Aleksandar Markovic <aleksandar.m.mail@gmail.com> wrote: > > 5:23 PM Sub, 15.02.2020. Philippe Mathieu-Daudé <f4bug@amsat.org> је написао/ла: > > > > User-mode does not need the sytem tools. Do not build them by > > default if user specified --disable-system. > > > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > > --- > > configure | 11 ++++++++++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > It would be nice if somebody comes up with more detailed analysis on what is built for --disable-system, but in fact not needed at all. This patch disable building the following binary on a user-only build: - elf2dmp - qemu-edid - qemu-ga - qemu-img - qemu-io - qemu-nbd - ivshmem-client - ivshmem-server Maybe Laurent can amend that to the description, else I can respin. > How does your change affect the size of the executable? Their size depends of the build option used (i.e. -ggdb vs -Os -s). The bigger difference is the build runs faster. > > diff --git a/configure b/configure > > index 16f94cd96b..557ca4bd04 100755 > > --- a/configure > > +++ b/configure > > @@ -455,7 +455,7 @@ guest_agent_ntddscsi="no" > > guest_agent_msi="" > > vss_win32_sdk="" > > win_sdk="no" > > -want_tools="yes" > > +want_tools="" > > libiscsi="" > > libnfs="" > > coroutine="" > > @@ -2199,6 +2199,15 @@ else > > echo big/little test failed > > fi > > > > +########################################## > > +# system tools > > +if test "$want_tools" != "yes" && test "$softmmu" = "no"; then > > + want_tools=no > > +fi > > +if test -z "$want_tools"; then > > + want_tools=yes > > +fi > > + > > ########################################## > > # cocoa implies not SDL or GTK > > # (the cocoa UI code currently assumes it is always the active UI > > -- > > 2.21.1 > > > >
diff --git a/configure b/configure index 16f94cd96b..557ca4bd04 100755 --- a/configure +++ b/configure @@ -455,7 +455,7 @@ guest_agent_ntddscsi="no" guest_agent_msi="" vss_win32_sdk="" win_sdk="no" -want_tools="yes" +want_tools="" libiscsi="" libnfs="" coroutine="" @@ -2199,6 +2199,15 @@ else echo big/little test failed fi +########################################## +# system tools +if test "$want_tools" != "yes" && test "$softmmu" = "no"; then + want_tools=no +fi +if test -z "$want_tools"; then + want_tools=yes +fi + ########################################## # cocoa implies not SDL or GTK # (the cocoa UI code currently assumes it is always the active UI
User-mode does not need the sytem tools. Do not build them by default if user specified --disable-system. Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- configure | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)