From patchwork Sat Feb 15 16:15:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1238578 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ik/OA6Fx; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48Kb3g3bJbz9sP7 for ; Sun, 16 Feb 2020 03:16:47 +1100 (AEDT) Received: from localhost ([::1]:52384 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j307Z-0002Xx-6l for incoming@patchwork.ozlabs.org; Sat, 15 Feb 2020 11:16:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47699) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j3071-0002Ey-F7 for qemu-devel@nongnu.org; Sat, 15 Feb 2020 11:16:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j3070-0005gk-DQ for qemu-devel@nongnu.org; Sat, 15 Feb 2020 11:16:11 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:52690 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j3070-0005fi-9s for qemu-devel@nongnu.org; Sat, 15 Feb 2020 11:16:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581783369; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pthG4sX1WmuDcM1pYL7nuZk6uLcNUXuiJV60qYY0Cuc=; b=ik/OA6FxrSQdfe2gIjtCbZAsrlXRFq3RXKHw0Tom2wwgg1EQ3J1cGzwrK+QctnCF3zU23m 28Mc8t32EIbUT1FIknBq2s3HEZLTOALgiDl7MIn2DRgoRMqKYVULrE04kqCfomjYvNQJyr 7oh+N51IzFZbUKF7iqO1V4H2QPTGaJs= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-256-T1FtHXOdOReZoR-8xe3pzA-1; Sat, 15 Feb 2020 11:16:06 -0500 Received: by mail-wr1-f71.google.com with SMTP id s13so5932122wrb.21 for ; Sat, 15 Feb 2020 08:16:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FnvdgJ+pULlElBjPbypj5ZtQBic6wsKotYOG0wxZcb4=; b=G/EqiyhQezSBBK4Gma1wIpeTO5DeQHES/8u/wFsBFGWaw1Y+vkT9KpAy9WAa7pTpds vYR3KI4u6k2mZUX++n7GVuSkNpQdugU5wB7XZQKxxiwQXNVtNlqtpsoqGIF1WaVBL7rM wuHgrHFQmUtoS4fzIJCJTbJzhJYD1fKpGnTqkOWhN4AzONqESvo76cCaKCLFg7v0BFRI jBylJPg7lBobyhm9PHiCYDHY6CaaOlcKJGcYRNXv46irP+CQZ01kz7YQm2iPdkgakCWA cGNEKqFJIoCIA7RvVKTNtr0uPwg/cmdVUp5AgnsBSpMbrHwC4/RS1ivWYCslrTPj0y+x nmdA== X-Gm-Message-State: APjAAAU0lxGUhb0ZOyW0xlf753j4N0lxIZwatmwI10QYTAeP604hS0Lw HdFcx2A+xG+8l26XoR4g+hVU6pP2swtPefuNFxbYWvwZ5vxSqpoS/2MCzMz12wZ4rjHwwo2Whao pQmTfOenaNlIlvbs= X-Received: by 2002:adf:fd0e:: with SMTP id e14mr10590725wrr.127.1581783364859; Sat, 15 Feb 2020 08:16:04 -0800 (PST) X-Google-Smtp-Source: APXvYqy/QDpZRjslcyFsFHRjtLnaMikvruJ3gCZAD8x7auXnoxru3hRQh1UJq8R17PhP9hIZE7mF9A== X-Received: by 2002:adf:fd0e:: with SMTP id e14mr10590704wrr.127.1581783364655; Sat, 15 Feb 2020 08:16:04 -0800 (PST) Received: from localhost.localdomain (78.red-88-21-202.staticip.rima-tde.net. [88.21.202.78]) by smtp.gmail.com with ESMTPSA id w26sm11855872wmi.8.2020.02.15.08.16.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Feb 2020 08:16:04 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 3/3] hw/block/pflash_cfi02: Remove unneeded variable assignment Date: Sat, 15 Feb 2020 17:15:57 +0100 Message-Id: <20200215161557.4077-4-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200215161557.4077-1-philmd@redhat.com> References: <20200215161557.4077-1-philmd@redhat.com> MIME-Version: 1.0 X-MC-Unique: T1FtHXOdOReZoR-8xe3pzA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org, qemu-trivial@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Max Reitz , Gerd Hoffmann , John Snow Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Fix warning reported by Clang static code analyzer: CC hw/block/pflash_cfi02.o hw/block/pflash_cfi02.c:311:5: warning: Value stored to 'ret' is never read ret = -1; ^ ~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- hw/block/pflash_cfi02.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c index 7c4744c020..12f18d401a 100644 --- a/hw/block/pflash_cfi02.c +++ b/hw/block/pflash_cfi02.c @@ -308,7 +308,6 @@ static uint64_t pflash_read(void *opaque, hwaddr offset, unsigned int width) hwaddr boff; uint64_t ret; - ret = -1; /* Lazy reset to ROMD mode after a certain amount of read accesses */ if (!pfl->rom_mode && pfl->wcycle == 0 && ++pfl->read_counter > PFLASH_LAZY_ROMD_THRESHOLD) {