| Message ID | 20200211203510.3534-2-alxndr@bu.edu |
|---|---|
| State | New |
| Headers | show |
| Series | Add virtual device fuzzing support | expand |
On Tue, Feb 11, 2020 at 03:34:48PM -0500, Alexander Bulekov wrote: > 524b4c2c5c moves vl.c into softmmu/ , breaking the checkpatch 524b4c2c5c is a local git sha1. That commit will have a different sha1 when applied to qemu.git/master. Saying "The next patch" instead would be fine. However, this patch leaves the tree in a state where checkpatch.pl will fail because softmmu/ doesn't exist yet! Please squash this patch into the next commit instead. I guess you kept it separate because changing checkpatch.pl can be thought of as a separate change. However, they two need to happen in a single step in order for checkpatch.pl to function correctly at each commit. Therefore it's appropriate to combine them into a single commit. > top-of-kernel-tree check. Replace with checks for softmmu and linux-user > > Signed-off-by: Alexander Bulekov <alxndr@bu.edu> > --- > scripts/checkpatch.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index ce43a306f8..2e2273b8a3 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -462,7 +462,7 @@ sub top_of_kernel_tree { > my @tree_check = ( > "COPYING", "MAINTAINERS", "Makefile", > "README.rst", "docs", "VERSION", > - "vl.c" > + "softmmu", "linux-user" > ); > > foreach my $check (@tree_check) { > -- > 2.25.0 >
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index ce43a306f8..2e2273b8a3 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -462,7 +462,7 @@ sub top_of_kernel_tree { my @tree_check = ( "COPYING", "MAINTAINERS", "Makefile", "README.rst", "docs", "VERSION", - "vl.c" + "softmmu", "linux-user" ); foreach my $check (@tree_check) {
524b4c2c5c moves vl.c into softmmu/ , breaking the checkpatch top-of-kernel-tree check. Replace with checks for softmmu and linux-user Signed-off-by: Alexander Bulekov <alxndr@bu.edu> --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)