From patchwork Sat Feb 1 19:29:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 1232314 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=snbapzR9; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4894VH3KgQz9s29 for ; Sun, 2 Feb 2020 06:51:51 +1100 (AEDT) Received: from localhost ([::1]:50162 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixyo1-000197-D7 for incoming@patchwork.ozlabs.org; Sat, 01 Feb 2020 14:51:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59008) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixyT1-000865-Lb for qemu-devel@nongnu.org; Sat, 01 Feb 2020 14:30:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ixyT0-0007It-Lm for qemu-devel@nongnu.org; Sat, 01 Feb 2020 14:30:07 -0500 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]:35109) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ixyT0-0007Gr-Ft for qemu-devel@nongnu.org; Sat, 01 Feb 2020 14:30:06 -0500 Received: by mail-pl1-x643.google.com with SMTP id g6so4182152plt.2 for ; Sat, 01 Feb 2020 11:30:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=l3ss3qHmQ8iAPtkBg17Hc7UVaIr08fmUa1mIsHxPys4=; b=snbapzR93c+nOgp07cmfvM7TpZEP9qBWCi5Jr2t+dJSZCXORXgg9qqJobkaLHv1EcJ JA42+ro/jXeE+CsEJlTdTrAoY0tO7RdFvC0XsTUkiDinVgIqhDkNH5tPsF5xjaGE28nX PCImzSvAtJgPMI5itTg+k1xvpPFzkz0xh6AQUgkwdf5J64ITJmUkX/wWTeU82cT4IjWo ffW2ULNVRldeRQUAcLAbnyEVo/6FgmyGnCcDtPTjRtnzc9BWwj9rhDT9NrIxjcuG9WjD m9wG0JP0/oGm3e+fOenQAKBYP6TBAUHfOFmV4IKpgMfdDM++ZFif3WRx28g1U5KJpuG/ WlbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=l3ss3qHmQ8iAPtkBg17Hc7UVaIr08fmUa1mIsHxPys4=; b=CFF8cPUzNeFc8TgxsB0ACuzq2DHZ+F6CnUty1/sO0KN99yKHJW+hqk6tPTQBRQ/q5d 43sFYydPqgO1x0BIuDZ0nFjmURXrXPUZzhMXWxXiNBoMTKuOYKiHCnxDxy+ytGROV9PI mtS8KtoWNuBCKp13zaEJnDsL+DGH5d4pbxBj7d98rGCZT2LNfMNdHWrYO+pwDYEOb5ei 6Mr91lEHaQpJ6wngPDl1IFkR/NfbWtNp9LHUABD+krh4hwPNk8dOavJ7F7XcAhbO+P/w MamNleZ45aiu2V0Tj3MM92qcTT/cMPjg8aveEgUVLEaUl0X+yhD5OMiTlDdZ8gDzoG7i fuFA== X-Gm-Message-State: APjAAAVu2B0RkdA17gj9ZZXr9DB3+gstXctB1pjuZpvPbdkF0bbn1XM2 Iy6UoRK4dDzSYkaQf2DEI/iPI+mfwiE= X-Google-Smtp-Source: APXvYqzRiFozttOmApw3zawjkw+d51C3mWszY6crQaNCyyMZI4mtytccXSi8lud45WoD4IWY1nHF/A== X-Received: by 2002:a17:902:6ac2:: with SMTP id i2mr15953152plt.221.1580585405281; Sat, 01 Feb 2020 11:30:05 -0800 (PST) Received: from localhost.localdomain (97-126-123-70.tukw.qwest.net. [97.126.123.70]) by smtp.gmail.com with ESMTPSA id l7sm3668509pga.27.2020.02.01.11.30.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Feb 2020 11:30:04 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v6 40/41] target/arm: Use bool for unmasked in arm_excp_unmasked Date: Sat, 1 Feb 2020 11:29:15 -0800 Message-Id: <20200201192916.31796-41-richard.henderson@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200201192916.31796-1-richard.henderson@linaro.org> References: <20200201192916.31796-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::643 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" The value computed is fully boolean; using int8_t is odd. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/arm/cpu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index fcee0a2dd4..4ffc09909d 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -417,7 +417,7 @@ static inline bool arm_excp_unmasked(CPUState *cs, unsigned int excp_idx, { CPUARMState *env = cs->env_ptr; bool pstate_unmasked; - int8_t unmasked = 0; + bool unmasked = false; /* * Don't take exceptions if they target a lower EL. @@ -468,7 +468,7 @@ static inline bool arm_excp_unmasked(CPUState *cs, unsigned int excp_idx, * don't affect the masking logic, only the interrupt routing. */ if (target_el == 3 || !secure) { - unmasked = 1; + unmasked = true; } } else { /* @@ -514,7 +514,7 @@ static inline bool arm_excp_unmasked(CPUState *cs, unsigned int excp_idx, } if ((scr || hcr) && !secure) { - unmasked = 1; + unmasked = true; } } }