diff mbox series

[rc1,18/24] hw/avr: Introduce ATMEL_ATMEGA_MCU config

Message ID 20200123000307.11541-19-richard.henderson@linaro.org
State New
Headers show
Series target/avr merger | expand

Commit Message

Richard Henderson Jan. 23, 2020, 12:03 a.m. UTC 
From: Philippe Mathieu-Daudé <f4bug@amsat.org>

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20200120220107.17825-13-f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 hw/avr/Kconfig | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 hw/avr/Kconfig

Comments

Thomas Huth Jan. 23, 2020, 5:04 a.m. UTC | #1 
On 23/01/2020 01.03, Richard Henderson wrote:
> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Message-Id: <20200120220107.17825-13-f4bug@amsat.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  hw/avr/Kconfig | 5 +++++
>  1 file changed, 5 insertions(+)
>  create mode 100644 hw/avr/Kconfig
> 
> diff --git a/hw/avr/Kconfig b/hw/avr/Kconfig
> new file mode 100644
> index 0000000000..da3b10afec
> --- /dev/null
> +++ b/hw/avr/Kconfig
> @@ -0,0 +1,5 @@
> +config ATMEL_ATMEGA_MCU
> +    bool
> +    select ATMEL_TIMER16
> +    select ATMEL_USART
> +    select ATMEL_POWER

Just my 0.02 €, but I'd rather squash it into the next patch.

 Thomas
Philippe Mathieu-Daudé Jan. 23, 2020, 5:27 p.m. UTC | #2 
On 1/23/20 6:04 AM, Thomas Huth wrote:
> On 23/01/2020 01.03, Richard Henderson wrote:
>> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> Message-Id: <20200120220107.17825-13-f4bug@amsat.org>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>>   hw/avr/Kconfig | 5 +++++
>>   1 file changed, 5 insertions(+)
>>   create mode 100644 hw/avr/Kconfig
>>
>> diff --git a/hw/avr/Kconfig b/hw/avr/Kconfig
>> new file mode 100644
>> index 0000000000..da3b10afec
>> --- /dev/null
>> +++ b/hw/avr/Kconfig
>> @@ -0,0 +1,5 @@
>> +config ATMEL_ATMEGA_MCU
>> +    bool
>> +    select ATMEL_TIMER16
>> +    select ATMEL_USART
>> +    select ATMEL_POWER
> 
> Just my 0.02 €, but I'd rather squash it into the next patch.

You are correct. I used a preliminary patch because the 'sample' board 
was still present in the series sent to Michael:
https://lists.gnu.org/archive/html/qemu-devel/2020-01/msg04384.html

Since Richard the Arduino boards replace it, we should squash this.
diff mbox series

Patch

diff --git a/hw/avr/Kconfig b/hw/avr/Kconfig
new file mode 100644
index 0000000000..da3b10afec
--- /dev/null
+++ b/hw/avr/Kconfig
@@ -0,0 +1,5 @@ 
+config ATMEL_ATMEGA_MCU
+    bool
+    select ATMEL_TIMER16
+    select ATMEL_USART
+    select ATMEL_POWER