| Message ID | 20200122055115.429945-1-mst@redhat.com |
|---|---|
| State | New |
| Headers | show |
Patchew URL: https://patchew.org/QEMU/20200122055115.429945-1-mst@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20200122055115.429945-1-mst@redhat.com
Subject: [PULL 00/17] virtio, pc: fixes, features
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
From https://github.com/patchew-project/qemu
* [new tag] patchew/20200122055115.429945-1-mst@redhat.com -> patchew/20200122055115.429945-1-mst@redhat.com
Switched to a new branch 'test'
dbbbe7b i386:acpi: Remove _HID from the SMBus ACPI entry
bd10a6b vhost: Only align sections for vhost-user
ab4696c vhost: Add names to section rounded warning
7c83ff2 vhost-vsock: delete vqs in vhost_vsock_unrealize to avoid memleaks
b7a6fa9 virtio-scsi: convert to new virtio_delete_queue
c151cac virtio-scsi: delete vqs in unrealize to avoid memleaks
43b2576 virtio-9p-device: convert to new virtio_delete_queue
233ede9 virtio-9p-device: fix memleak in virtio_9p_device_unrealize
cbca7b4 bios-tables-test: document expected file update
889245c acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command
d693954 acpi: cpuhp: spec: add typical usecases
1c967e4 acpi: cpuhp: introduce 'Command data 2' field
2c87154 acpi: cpuhp: spec: clarify store into 'Command data' when 'Command field' == 0
875e2af acpi: cpuhp: spec: fix 'Command data' description
16c15d6 acpi: cpuhp: spec: clarify 'CPU selector' register usage and endianness
b3207b3 tests: q35: MCH: add default SMBASE SMRAM lock test
02823db q35: implement 128K SMRAM at default SMBASE address
=== OUTPUT BEGIN ===
1/17 Checking commit 02823db3437d (q35: implement 128K SMRAM at default SMBASE address)
2/17 Checking commit b3207b3998a9 (tests: q35: MCH: add default SMBASE SMRAM lock test)
3/17 Checking commit 16c15d6ab057 (acpi: cpuhp: spec: clarify 'CPU selector' register usage and endianness)
4/17 Checking commit 875e2af092e9 (acpi: cpuhp: spec: fix 'Command data' description)
5/17 Checking commit 2c871544d986 (acpi: cpuhp: spec: clarify store into 'Command data' when 'Command field' == 0)
6/17 Checking commit 1c967e4c7e0a (acpi: cpuhp: introduce 'Command data 2' field)
7/17 Checking commit d693954ab6e4 (acpi: cpuhp: spec: add typical usecases)
8/17 Checking commit 889245cb021f (acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command)
9/17 Checking commit cbca7b4cc4b0 (bios-tables-test: document expected file update)
WARNING: line over 80 characters
#23: FILE: tests/qtest/bios-tables-test.c:20:
+ * Contributor or ACPI Maintainer (steps 4-7 need to be redone to resolve conflicts
total: 0 errors, 1 warnings, 38 lines checked
Patch 9/17 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/17 Checking commit 233ede934524 (virtio-9p-device: fix memleak in virtio_9p_device_unrealize)
11/17 Checking commit 43b25766fe8d (virtio-9p-device: convert to new virtio_delete_queue)
12/17 Checking commit c151cac0ebf8 (virtio-scsi: delete vqs in unrealize to avoid memleaks)
13/17 Checking commit b7a6fa987abb (virtio-scsi: convert to new virtio_delete_queue)
14/17 Checking commit 7c83ff29ef1f (vhost-vsock: delete vqs in vhost_vsock_unrealize to avoid memleaks)
15/17 Checking commit ab4696cfca2a (vhost: Add names to section rounded warning)
16/17 Checking commit bd10a6b17eb6 (vhost: Only align sections for vhost-user)
ERROR: trailing whitespace
#49: FILE: hw/virtio/vhost.c:554:
+ if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) { $
WARNING: line over 80 characters
#64: FILE: hw/virtio/vhost.c:569:
+ trace_vhost_region_add_section_aligned(section->mr->name, mrs_gpa, mrs_size,
total: 1 errors, 1 warnings, 43 lines checked
Patch 16/17 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/17 Checking commit dbbbe7b4ff3d (i386:acpi: Remove _HID from the SMBus ACPI entry)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200122055115.429945-1-mst@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20200122055115.429945-1-mst@redhat.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===
Using expected file 'tests/data/acpi/q35/DSDT.acpihmat'
acpi-test: Warning! DSDT binary file mismatch. Actual [aml:/tmp/aml-JWZVE0], Expected [aml:tests/data/acpi/q35/DSDT.acpihmat].
to see ASL diff between mismatched files install IASL, rebuild QEMU from scratch and re-run tests with V=1 environment variable set**
ERROR:/tmp/qemu-test/src/tests/qtest/bios-tables-test.c:490:test_acpi_asl: assertion failed: (all_tables_match)
ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/qtest/bios-tables-test.c:490:test_acpi_asl: assertion failed: (all_tables_match)
make: *** [check-qtest-x86_64] Error 1
make: *** Waiting for unfinished jobs....
TEST iotest-qcow2: 049
TEST iotest-qcow2: 050
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=bf9f3c03d7fd4eeab2985d10a998dce8', '-u', '1001', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-7wut4nre/src/docker-src.2020-01-22-01.10.32.9979:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=bf9f3c03d7fd4eeab2985d10a998dce8
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-7wut4nre/src'
make: *** [docker-run-test-quick@centos7] Error 2
real 12m59.608s
user 0m10.933s
The full log is available at
http://patchew.org/logs/20200122055115.429945-1-mst@redhat.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
On Tue, Jan 21, 2020 at 10:23:32PM -0800, no-reply@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20200122055115.429945-1-mst@redhat.com/ > > > > Hi, > > This series failed the docker-quick@centos7 build test. Please find the testing commands and > their output below. If you have Docker installed, you can probably reproduce it > locally. Oops. Trying to figure out what went wrong now. > === TEST SCRIPT BEGIN === > #!/bin/bash > make docker-image-centos7 V=1 NETWORK=1 > time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1 > === TEST SCRIPT END === > > Using expected file 'tests/data/acpi/q35/DSDT.acpihmat' > acpi-test: Warning! DSDT binary file mismatch. Actual [aml:/tmp/aml-JWZVE0], Expected [aml:tests/data/acpi/q35/DSDT.acpihmat]. > to see ASL diff between mismatched files install IASL, rebuild QEMU from scratch and re-run tests with V=1 environment variable set** > ERROR:/tmp/qemu-test/src/tests/qtest/bios-tables-test.c:490:test_acpi_asl: assertion failed: (all_tables_match) > ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/qtest/bios-tables-test.c:490:test_acpi_asl: assertion failed: (all_tables_match) > make: *** [check-qtest-x86_64] Error 1 > make: *** Waiting for unfinished jobs.... > TEST iotest-qcow2: 049 > TEST iotest-qcow2: 050 > --- > raise CalledProcessError(retcode, cmd) > subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=bf9f3c03d7fd4eeab2985d10a998dce8', '-u', '1001', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-7wut4nre/src/docker-src.2020-01-22-01.10.32.9979:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2. > filter=--filter=label=com.qemu.instance.uuid=bf9f3c03d7fd4eeab2985d10a998dce8 > make[1]: *** [docker-run] Error 1 > make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-7wut4nre/src' > make: *** [docker-run-test-quick@centos7] Error 2 > > real 12m59.608s > user 0m10.933s > > > The full log is available at > http://patchew.org/logs/20200122055115.429945-1-mst@redhat.com/testing.docker-quick@centos7/?type=message. > --- > Email generated automatically by Patchew [https://patchew.org/]. > Please send your feedback to patchew-devel@redhat.com
On Tue, Jan 21, 2020 at 10:23:32PM -0800, no-reply@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20200122055115.429945-1-mst@redhat.com/ > > > > Hi, > > This series failed the docker-quick@centos7 build test. Please find the testing commands and > their output below. If you have Docker installed, you can probably reproduce it > locally. OK just a missing expected file. Will send v2. > === TEST SCRIPT BEGIN === > #!/bin/bash > make docker-image-centos7 V=1 NETWORK=1 > time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1 > === TEST SCRIPT END === > > Using expected file 'tests/data/acpi/q35/DSDT.acpihmat' > acpi-test: Warning! DSDT binary file mismatch. Actual [aml:/tmp/aml-JWZVE0], Expected [aml:tests/data/acpi/q35/DSDT.acpihmat]. > to see ASL diff between mismatched files install IASL, rebuild QEMU from scratch and re-run tests with V=1 environment variable set** > ERROR:/tmp/qemu-test/src/tests/qtest/bios-tables-test.c:490:test_acpi_asl: assertion failed: (all_tables_match) > ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/qtest/bios-tables-test.c:490:test_acpi_asl: assertion failed: (all_tables_match) > make: *** [check-qtest-x86_64] Error 1 > make: *** Waiting for unfinished jobs.... > TEST iotest-qcow2: 049 > TEST iotest-qcow2: 050 > --- > raise CalledProcessError(retcode, cmd) > subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=bf9f3c03d7fd4eeab2985d10a998dce8', '-u', '1001', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-7wut4nre/src/docker-src.2020-01-22-01.10.32.9979:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2. > filter=--filter=label=com.qemu.instance.uuid=bf9f3c03d7fd4eeab2985d10a998dce8 > make[1]: *** [docker-run] Error 1 > make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-7wut4nre/src' > make: *** [docker-run-test-quick@centos7] Error 2 > > real 12m59.608s > user 0m10.933s > > > The full log is available at > http://patchew.org/logs/20200122055115.429945-1-mst@redhat.com/testing.docker-quick@centos7/?type=message. > --- > Email generated automatically by Patchew [https://patchew.org/]. > Please send your feedback to patchew-devel@redhat.com
The following changes since commit 3e08b2b9cb64bff2b73fa9128c0e49bfcde0dd40: Merge remote-tracking branch 'remotes/philmd-gitlab/tags/edk2-next-20200121' into staging (2020-01-21 15:29:25 +0000) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to b214ce61b60faa8b7629645824889bc01a07df0e: i386:acpi: Remove _HID from the SMBus ACPI entry (2020-01-22 00:50:03 -0500) ---------------------------------------------------------------- virtio, pc: fixes, features Bugfixes all over the place. CPU hotplug with secureboot. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> ---------------------------------------------------------------- Corey Minyard (1): i386:acpi: Remove _HID from the SMBus ACPI entry Dr. David Alan Gilbert (2): vhost: Add names to section rounded warning vhost: Only align sections for vhost-user Igor Mammedov (8): q35: implement 128K SMRAM at default SMBASE address tests: q35: MCH: add default SMBASE SMRAM lock test acpi: cpuhp: spec: clarify 'CPU selector' register usage and endianness acpi: cpuhp: spec: fix 'Command data' description acpi: cpuhp: spec: clarify store into 'Command data' when 'Command field' == 0 acpi: cpuhp: introduce 'Command data 2' field acpi: cpuhp: spec: add typical usecases acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command Michael S. Tsirkin (1): bios-tables-test: document expected file update Pan Nengyuan (5): virtio-9p-device: fix memleak in virtio_9p_device_unrealize virtio-9p-device: convert to new virtio_delete_queue virtio-scsi: delete vqs in unrealize to avoid memleaks virtio-scsi: convert to new virtio_delete_queue vhost-vsock: delete vqs in vhost_vsock_unrealize to avoid memleaks docs/specs/acpi_cpu_hotplug.txt | 89 ++++++++++++++++++++++++++------- include/hw/pci-host/q35.h | 10 ++++ include/hw/virtio/vhost-vsock.h | 2 + hw/9pfs/virtio-9p-device.c | 1 + hw/acpi/cpu.c | 18 +++++++ hw/i386/acpi-build.c | 1 - hw/i386/pc.c | 4 +- hw/pci-host/q35.c | 84 ++++++++++++++++++++++++++++--- hw/scsi/virtio-scsi.c | 6 +++ hw/virtio/vhost-vsock.c | 12 ++++- hw/virtio/vhost.c | 39 ++++++++------- tests/qtest/bios-tables-test.c | 23 +++++++-- tests/qtest/q35-test.c | 105 +++++++++++++++++++++++++++++++++++++++ hw/acpi/trace-events | 1 + tests/data/acpi/q35/DSDT | Bin 7879 -> 7869 bytes tests/data/acpi/q35/DSDT.bridge | Bin 7896 -> 7886 bytes tests/data/acpi/q35/DSDT.cphp | Bin 8342 -> 8332 bytes tests/data/acpi/q35/DSDT.dimmpxm | Bin 9532 -> 9522 bytes tests/data/acpi/q35/DSDT.ipmibt | Bin 7954 -> 7944 bytes tests/data/acpi/q35/DSDT.memhp | Bin 9238 -> 9228 bytes tests/data/acpi/q35/DSDT.mmio64 | Bin 9009 -> 8999 bytes tests/data/acpi/q35/DSDT.numamem | Bin 7885 -> 7875 bytes 22 files changed, 344 insertions(+), 51 deletions(-)