From patchwork Tue Jan 21 12:23:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Dr. David Alan Gilbert" X-Patchwork-Id: 1226472 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=gyMMwNua; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4827jS19p1z9sRG for ; Tue, 21 Jan 2020 23:52:28 +1100 (AEDT) Received: from localhost ([::1]:53360 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itt17-0007S6-ES for incoming@patchwork.ozlabs.org; Tue, 21 Jan 2020 07:52:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51283) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itsby-0006ah-RO for qemu-devel@nongnu.org; Tue, 21 Jan 2020 07:26:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itsbu-00028a-Up for qemu-devel@nongnu.org; Tue, 21 Jan 2020 07:26:26 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:27093 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1itsbu-00028P-RC for qemu-devel@nongnu.org; Tue, 21 Jan 2020 07:26:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579609582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bOtqUmVYNx1EDbz3WmBHLjBYkS+xcfWXJ/b7wfmU4XI=; b=gyMMwNuaJAG1qdLDqPGrU93Wpzl2I/SKGkNbXcgyoFv0eC0pUJG1nwDVkz3rg+ew+NffhF VxnMyeN5kmqgBLchQHwxQ8uU1EwkRl2LoZdA5gjrGSP12ns1b+91YcnHCRQ2rIKWDwC17W q6US1zK7ypCgscOE1J62WTKo1EI1HVg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-17-xzCkJlbbOIu9UO2g85qo_Q-1; Tue, 21 Jan 2020 07:26:21 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1BA921005514; Tue, 21 Jan 2020 12:26:20 +0000 (UTC) Received: from dgilbert-t580.localhost (unknown [10.36.118.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id D4BDF60BE0; Tue, 21 Jan 2020 12:26:14 +0000 (UTC) From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, stefanha@redhat.com, vgoyal@redhat.com, berrange@redhat.com, slp@redhat.com, philmd@redhat.com Subject: [PATCH v2 023/109] virtiofsd: Start reading commands from queue Date: Tue, 21 Jan 2020 12:23:07 +0000 Message-Id: <20200121122433.50803-24-dgilbert@redhat.com> In-Reply-To: <20200121122433.50803-1-dgilbert@redhat.com> References: <20200121122433.50803-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: xzCkJlbbOIu9UO2g85qo_Q-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: m.mizuma@jp.fujitsu.com, misono.tomohiro@jp.fujitsu.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: "Dr. David Alan Gilbert" Pop queue elements off queues, copy the data from them and pass that to fuse. Note: 'out' in a VuVirtqElement is from QEMU 'in' in libfuse is into the daemon So we read from the out iov's to get a fuse_in_header When we get a kick we've got to read all the elements until the queue is empty. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Daniel P. Berrangé --- tools/virtiofsd/fuse_i.h | 2 + tools/virtiofsd/fuse_virtio.c | 99 +++++++++++++++++++++++++++++++++-- 2 files changed, 98 insertions(+), 3 deletions(-) diff --git a/tools/virtiofsd/fuse_i.h b/tools/virtiofsd/fuse_i.h index ec04449069..1126723d18 100644 --- a/tools/virtiofsd/fuse_i.h +++ b/tools/virtiofsd/fuse_i.h @@ -14,6 +14,7 @@ #include "fuse_lowlevel.h" struct fv_VuDev; +struct fv_QueueInfo; struct fuse_req { struct fuse_session *se; @@ -75,6 +76,7 @@ struct fuse_chan { pthread_mutex_t lock; int ctr; int fd; + struct fv_QueueInfo *qi; }; /** diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c index 05e7258712..3841b20129 100644 --- a/tools/virtiofsd/fuse_virtio.c +++ b/tools/virtiofsd/fuse_virtio.c @@ -12,6 +12,7 @@ */ #include "qemu/osdep.h" +#include "qemu/iov.h" #include "fuse_virtio.h" #include "fuse_i.h" #include "standard-headers/linux/fuse.h" @@ -32,6 +33,7 @@ #include "contrib/libvhost-user/libvhost-user.h" +struct fv_VuDev; struct fv_QueueInfo { pthread_t thread; struct fv_VuDev *virtio_dev; @@ -101,10 +103,41 @@ static void fv_panic(VuDev *dev, const char *err) exit(EXIT_FAILURE); } +/* + * Copy from an iovec into a fuse_buf (memory only) + * Caller must ensure there is space + */ +static void copy_from_iov(struct fuse_buf *buf, size_t out_num, + const struct iovec *out_sg) +{ + void *dest = buf->mem; + + while (out_num) { + size_t onelen = out_sg->iov_len; + memcpy(dest, out_sg->iov_base, onelen); + dest += onelen; + out_sg++; + out_num--; + } +} + /* Thread function for individual queues, created when a queue is 'started' */ static void *fv_queue_thread(void *opaque) { struct fv_QueueInfo *qi = opaque; + struct VuDev *dev = &qi->virtio_dev->dev; + struct VuVirtq *q = vu_get_queue(dev, qi->qidx); + struct fuse_session *se = qi->virtio_dev->se; + struct fuse_chan ch; + struct fuse_buf fbuf; + + fbuf.mem = NULL; + fbuf.flags = 0; + + fuse_mutex_init(&ch.lock); + ch.fd = (int)0xdaff0d111; + ch.qi = qi; + fuse_log(FUSE_LOG_INFO, "%s: Start for queue %d kick_fd %d\n", __func__, qi->qidx, qi->kick_fd); while (1) { @@ -141,11 +174,71 @@ static void *fv_queue_thread(void *opaque) fuse_log(FUSE_LOG_ERR, "Eventfd_read for queue: %m\n"); break; } - if (qi->virtio_dev->se->debug) { - fprintf(stderr, "%s: Queue %d gave evalue: %zx\n", __func__, - qi->qidx, (size_t)evalue); + /* out is from guest, in is too guest */ + unsigned int in_bytes, out_bytes; + vu_queue_get_avail_bytes(dev, q, &in_bytes, &out_bytes, ~0, ~0); + + fuse_log(FUSE_LOG_DEBUG, + "%s: Queue %d gave evalue: %zx available: in: %u out: %u\n", + __func__, qi->qidx, (size_t)evalue, in_bytes, out_bytes); + + while (1) { + /* + * An element contains one request and the space to send our + * response They're spread over multiple descriptors in a + * scatter/gather set and we can't trust the guest to keep them + * still; so copy in/out. + */ + VuVirtqElement *elem = vu_queue_pop(dev, q, sizeof(VuVirtqElement)); + if (!elem) { + break; + } + + if (!fbuf.mem) { + fbuf.mem = malloc(se->bufsize); + assert(fbuf.mem); + assert(se->bufsize > sizeof(struct fuse_in_header)); + } + /* The 'out' part of the elem is from qemu */ + unsigned int out_num = elem->out_num; + struct iovec *out_sg = elem->out_sg; + size_t out_len = iov_size(out_sg, out_num); + fuse_log(FUSE_LOG_DEBUG, + "%s: elem %d: with %d out desc of length %zd\n", __func__, + elem->index, out_num, out_len); + + /* + * The elem should contain a 'fuse_in_header' (in to fuse) + * plus the data based on the len in the header. + */ + if (out_len < sizeof(struct fuse_in_header)) { + fuse_log(FUSE_LOG_ERR, "%s: elem %d too short for in_header\n", + __func__, elem->index); + assert(0); /* TODO */ + } + if (out_len > se->bufsize) { + fuse_log(FUSE_LOG_ERR, "%s: elem %d too large for buffer\n", + __func__, elem->index); + assert(0); /* TODO */ + } + copy_from_iov(&fbuf, out_num, out_sg); + fbuf.size = out_len; + + /* TODO! Endianness of header */ + + /* TODO: Fixup fuse_send_msg */ + /* TODO: Add checks for fuse_session_exited */ + fuse_session_process_buf_int(se, &fbuf, &ch); + + /* TODO: vu_queue_push(dev, q, elem, qi->write_count); */ + vu_queue_notify(dev, q); + + free(elem); + elem = NULL; } } + pthread_mutex_destroy(&ch.lock); + free(fbuf.mem); return NULL; }