From patchwork Wed Jan 15 12:23:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Kevin Wolf X-Patchwork-Id: 1223422 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=NmKOm+9B; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47yRSc3dfpz9sR0 for ; Wed, 15 Jan 2020 23:28:32 +1100 (AEDT) Received: from localhost ([::1]:53068 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irhmg-0003hk-Cg for incoming@patchwork.ozlabs.org; Wed, 15 Jan 2020 07:28:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47656) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irhiA-0006Tt-9i for qemu-devel@nongnu.org; Wed, 15 Jan 2020 07:23:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1irhi6-00023w-Aj for qemu-devel@nongnu.org; Wed, 15 Jan 2020 07:23:50 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:50188 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1irhi6-00023V-7Z for qemu-devel@nongnu.org; Wed, 15 Jan 2020 07:23:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579091025; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=svotTECI5zrSZmuvFDCvoQ7OyS3LuOvNA4K0YneyOdQ=; b=NmKOm+9BA/4yXqd/GpjpJiJNjEmMI8r2ROlcWkCVq8IjhKyGKwgFc//eoZbtQgMoO8qMM8 Ai+L92mYemPLRnOpsIOV8Tw/rEyp6c4U49uJ4vlXsWIxhhPv2QauadL3YNFdbe4KTlAR/n I1/4OrWrl0UFF77vjSrPhL19+88enlI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-362-cdah8LoOP_CRyYK_ZhKPsA-1; Wed, 15 Jan 2020 07:23:42 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5839E106BF9C; Wed, 15 Jan 2020 12:23:41 +0000 (UTC) Received: from linux.fritz.box.com (ovpn-117-87.ams2.redhat.com [10.36.117.87]) by smtp.corp.redhat.com (Postfix) with ESMTP id DAF655C1D6; Wed, 15 Jan 2020 12:23:39 +0000 (UTC) From: Kevin Wolf To: qemu-devel@nongnu.org Subject: [PATCH v3 4/4] block: Mark 'block_resize' as coroutine Date: Wed, 15 Jan 2020 13:23:26 +0100 Message-Id: <20200115122326.26393-5-kwolf@redhat.com> In-Reply-To: <20200115122326.26393-1-kwolf@redhat.com> References: <20200115122326.26393-1-kwolf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: cdah8LoOP_CRyYK_ZhKPsA-1 X-Mimecast-Spam-Score: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, qemu-block@nongnu.org, armbru@redhat.com, marcandre.lureau@gmail.com, stefanha@redhat.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" block_resize is safe to run in a coroutine, so use it as an example for the new 'coroutine': true annotation in the QAPI schema. Signed-off-by: Kevin Wolf Reviewed-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- qapi/block-core.json | 3 ++- blockdev.c | 6 +++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 7ff5e5edaf..1dbb2a9901 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -1341,7 +1341,8 @@ { 'command': 'block_resize', 'data': { '*device': 'str', '*node-name': 'str', - 'size': 'int' } } + 'size': 'int' }, + 'coroutine': true } ## # @NewImageMode: diff --git a/blockdev.c b/blockdev.c index 8e029e9c01..b5e5d1e072 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3161,9 +3161,9 @@ void hmp_drive_del(Monitor *mon, const QDict *qdict) aio_context_release(aio_context); } -void qmp_block_resize(bool has_device, const char *device, - bool has_node_name, const char *node_name, - int64_t size, Error **errp) +void coroutine_fn qmp_block_resize(bool has_device, const char *device, + bool has_node_name, const char *node_name, + int64_t size, Error **errp) { Error *local_err = NULL; BlockBackend *blk = NULL;