| Message ID | 20191218172009.8868-11-philmd@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | chardev: Use QEMUChrEvent enum in IOEventHandler typedef | expand |
On Wed, Dec 18, 2019 at 06:20:05PM +0100, Philippe Mathieu-Daudé wrote: > The Chardev events are listed in the QEMUChrEvent enum. To be > able to use this enum in the IOEventHandler typedef, we need to > explicit all the events ignored by this frontend, to silent the > following GCC warning: > > CC hw/char/virtio-console.o > hw/char/virtio-console.c: In function ‘chr_event’: > hw/char/virtio-console.c:154:5: error: enumeration value ‘CHR_EVENT_BREAK’ not handled in switch [-Werror=switch] > 154 | switch (event) { > | ^~~~~~ > hw/char/virtio-console.c:154:5: error: enumeration value ‘CHR_EVENT_MUX_IN’ not handled in switch [-Werror=switch] > hw/char/virtio-console.c:154:5: error: enumeration value ‘CHR_EVENT_MUX_OUT’ not handled in switch [-Werror=switch] > cc1: all warnings being treated as errors > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > v2: Add all missing enums > > Cc: "Michael S. Tsirkin" <mst@redhat.com> > Cc: Laurent Vivier <lvivier@redhat.com> > Cc: Amit Shah <amit@kernel.org> > Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com> > Cc: Paolo Bonzini <pbonzini@redhat.com> Acked-by: Michael S. Tsirkin <mst@redhat.com> > --- > hw/char/virtio-console.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/hw/char/virtio-console.c b/hw/char/virtio-console.c > index c13649f1ef..cbb304d270 100644 > --- a/hw/char/virtio-console.c > +++ b/hw/char/virtio-console.c > @@ -162,6 +162,11 @@ static void chr_event(void *opaque, int event) > } > virtio_serial_close(port); > break; > + case CHR_EVENT_BREAK: > + case CHR_EVENT_MUX_IN: > + case CHR_EVENT_MUX_OUT: > + /* Ignore */ > + break; > } > } > > -- > 2.21.0
diff --git a/hw/char/virtio-console.c b/hw/char/virtio-console.c index c13649f1ef..cbb304d270 100644 --- a/hw/char/virtio-console.c +++ b/hw/char/virtio-console.c @@ -162,6 +162,11 @@ static void chr_event(void *opaque, int event) } virtio_serial_close(port); break; + case CHR_EVENT_BREAK: + case CHR_EVENT_MUX_IN: + case CHR_EVENT_MUX_OUT: + /* Ignore */ + break; } }
The Chardev events are listed in the QEMUChrEvent enum. To be able to use this enum in the IOEventHandler typedef, we need to explicit all the events ignored by this frontend, to silent the following GCC warning: CC hw/char/virtio-console.o hw/char/virtio-console.c: In function ‘chr_event’: hw/char/virtio-console.c:154:5: error: enumeration value ‘CHR_EVENT_BREAK’ not handled in switch [-Werror=switch] 154 | switch (event) { | ^~~~~~ hw/char/virtio-console.c:154:5: error: enumeration value ‘CHR_EVENT_MUX_IN’ not handled in switch [-Werror=switch] hw/char/virtio-console.c:154:5: error: enumeration value ‘CHR_EVENT_MUX_OUT’ not handled in switch [-Werror=switch] cc1: all warnings being treated as errors Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- v2: Add all missing enums Cc: "Michael S. Tsirkin" <mst@redhat.com> Cc: Laurent Vivier <lvivier@redhat.com> Cc: Amit Shah <amit@kernel.org> Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com> Cc: Paolo Bonzini <pbonzini@redhat.com> --- hw/char/virtio-console.c | 5 +++++ 1 file changed, 5 insertions(+)