Message ID | 20191212185424.4675-1-thuth@redhat.com |
---|---|
State | New |
Headers | show |
On Thu, 12 Dec 2019 at 18:54, Thomas Huth <thuth@redhat.com> wrote: > > Hi, > > the following changes since commit 52901abf94477b400cf88c1f70bb305e690ba2de: > > Update version for v4.2.0-rc5 release (2019-12-10 17:15:21 +0000) > > are available in the Git repository at: > > https://gitlab.com/huth/qemu.git tags/pull-request-2019-12-12 > > for you to fetch changes up to e38f04c4db40a9219cc0c516a6c68b9ca0a783d0: > > tests: use g_test_rand_int (2019-12-12 08:16:24 +0100) > > ---------------------------------------------------------------- > - Removal of the deprecated bluetooth code > - Some qtest and misc patches > ---------------------------------------------------------------- Hi; this fails to build on some of my build hosts: OSX: [...] GEN target/sparc/trace.c GEN util/trace.c GEN hw/core/trace.c CC qga/main.o CC qemu-nbd.o CC qemu-img.o make: *** No rule to make target `config-all-devices.mak', needed by `aarch64-softmmu/all'. Stop. make: *** Waiting for unfinished jobs.... ppc64 linux: CC chardev/char-mux.o CC chardev/char-null.o CC chardev/char-parallel.o CC chardev/char-pipe.o CC chardev/char-pty.o CC chardev/char-ringbuf.o CC chardev/char-serial.o CC chardev/char-socket.o CC chardev/char-stdio.o make: *** No rule to make target `/home/pm215/qemu/hw/bt/Kconfig', needed by `aarch64-softmmu/config-devices.mak'. Stop. make: *** Waiting for unfinished jobs.... CC chardev/char-udp.o make: Leaving directory `/home/pm215/qemu/build/all' windows crossbuilds: CC chardev/char-serial.o CC chardev/char-socket.o CC chardev/char-stdio.o CC chardev/char-udp.o CC chardev/char-win.o make: *** No rule to make target '/home/petmay01/qemu-for-merges/hw/bt/Kconfig', needed by 'aarch64-softmmu/config-devices.mak'. Stop. make: *** Waiting for unfinished jobs.... CC chardev/char-win-stdio.o It's possible this is a lurking bug in our makefiles where it doesn't regenerate the config-devices dependencies properly; I'm not sure and haven't investigated. thanks -- PMM
On 16/12/2019 11.27, Peter Maydell wrote: > On Thu, 12 Dec 2019 at 18:54, Thomas Huth <thuth@redhat.com> wrote: >> >> Hi, >> >> the following changes since commit 52901abf94477b400cf88c1f70bb305e690ba2de: >> >> Update version for v4.2.0-rc5 release (2019-12-10 17:15:21 +0000) >> >> are available in the Git repository at: >> >> https://gitlab.com/huth/qemu.git tags/pull-request-2019-12-12 >> >> for you to fetch changes up to e38f04c4db40a9219cc0c516a6c68b9ca0a783d0: >> >> tests: use g_test_rand_int (2019-12-12 08:16:24 +0100) >> >> ---------------------------------------------------------------- >> - Removal of the deprecated bluetooth code >> - Some qtest and misc patches >> ---------------------------------------------------------------- > > Hi; this fails to build on some of my build hosts: > > OSX: > [...] > GEN target/sparc/trace.c > GEN util/trace.c > GEN hw/core/trace.c > CC qga/main.o > CC qemu-nbd.o > CC qemu-img.o > make: *** No rule to make target `config-all-devices.mak', needed by > `aarch64-softmmu/all'. Stop. > make: *** Waiting for unfinished jobs.... I unfortunately can't reproduce the issue, but if you've got some spare minutes, could you please check whether this patch helps: diff --git a/Makefile b/Makefile index b437a346d7..23aae1437b 100644 --- a/Makefile +++ b/Makefile @@ -365,7 +365,8 @@ ifeq ($(SUBDIR_DEVICES_MAK),) config-all-devices.mak: config-host.mak $(call quiet-command,echo '# no devices' > $@,"GEN","$@") else -config-all-devices.mak: $(SUBDIR_DEVICES_MAK) config-host.mak +config-all-devices.mak: $(SUBDIR_DEVICES_MAK) config-host.mak \ + $(SRC_PATH)/hw/Kconfig $(call quiet-command, sed -n \ 's|^\([^=]*\)=\(.*\)$$|\1:=$$(findstring y,$$(\1)\2)|p' \ $(SUBDIR_DEVICES_MAK) | sort -u > $@, \ ? > ppc64 linux: > CC chardev/char-mux.o > CC chardev/char-null.o > CC chardev/char-parallel.o > CC chardev/char-pipe.o > CC chardev/char-pty.o > CC chardev/char-ringbuf.o > CC chardev/char-serial.o > CC chardev/char-socket.o > CC chardev/char-stdio.o > make: *** No rule to make target `/home/pm215/qemu/hw/bt/Kconfig', > needed by `aarch64-softmmu/config-devices.mak'. Stop. > make: *** Waiting for unfinished jobs.... > CC chardev/char-udp.o > make: Leaving directory `/home/pm215/qemu/build/all' > > > windows crossbuilds: > CC chardev/char-serial.o > CC chardev/char-socket.o > CC chardev/char-stdio.o > CC chardev/char-udp.o > CC chardev/char-win.o > make: *** No rule to make target > '/home/petmay01/qemu-for-merges/hw/bt/Kconfig', needed by > 'aarch64-softmmu/config-devices.mak'. Stop. > make: *** Waiting for unfinished jobs.... > CC chardev/char-win-stdio.o These ones are really surprising to me ... *-softmmu/config-devices.mak should have a proper dependency on hw/Kconfig so they should get properly rebuild as far as I can tell. Could you please check the *-softmmu/config-devices.mak.d dependency files whether the dependency on hw/Kconfig is really there? Hmm, maybe "make" also tries to check the old dependency to hw/bt/Kconfig first, before regenerating the files ... not sure how to fix this properly, maybe leave an empty hw/bt/Kconfig around for a while 'til all build systems have regenerated the dependency files? Thomas
On 16/12/19 13:08, Thomas Huth wrote: >> windows crossbuilds: >> CC chardev/char-serial.o >> CC chardev/char-socket.o >> CC chardev/char-stdio.o >> CC chardev/char-udp.o >> CC chardev/char-win.o >> make: *** No rule to make target >> '/home/petmay01/qemu-for-merges/hw/bt/Kconfig', needed by >> 'aarch64-softmmu/config-devices.mak'. Stop. >> make: *** Waiting for unfinished jobs.... >> CC chardev/char-win-stdio.o > These ones are really surprising to me ... *-softmmu/config-devices.mak > should have a proper dependency on hw/Kconfig so they should get > properly rebuild as far as I can tell. Could you please check the > *-softmmu/config-devices.mak.d dependency files whether the dependency > on hw/Kconfig is really there? Hmm, maybe "make" also tries to check the > old dependency to hw/bt/Kconfig first, before regenerating the files ... > not sure how to fix this properly, maybe leave an empty hw/bt/Kconfig > around for a while 'til all build systems have regenerated the > dependency files? I think in the past we've had patches where you just had to force a "make distclean". Paolo