| Message ID | 20191028073441.6448-5-philmd@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | tests/acceptance: Queue for 4.2 | expand |
On Mon, Oct 28, 2019 at 08:34:19AM +0100, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé <f4bug@amsat.org> > > Some firmwares don't parse the <Newline> control character and > expect a <carriage return>. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > since previous: do not send NewLine > --- > tests/acceptance/boot_linux_console.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py > index 8897e0c253..f9b77af359 100644 > --- a/tests/acceptance/boot_linux_console.py > +++ b/tests/acceptance/boot_linux_console.py > @@ -34,7 +34,7 @@ class BootLinuxConsole(Test): > failure_message='Kernel panic - not syncing') > > def exec_command_and_wait_for_pattern(self, command, success_message): > - command += '\n' > + command += '\r' > self.vm.console_socket.sendall(command.encode()) > wait_for_console_pattern(self, success_message) > > -- > 2.21.0 > Given the discussion on <d21da354-0c14-5b55-0e87-1a63d246e4ca@amsat.org>, this LGTM. Reviewed-by: Cleber Rosa <crosa@redhat.com> Tested-by: Cleber Rosa <crosa@redhat.com> Queuing on my python-next branch (and sending shortly in a PR). Thanks, - Cleber.
diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py index 8897e0c253..f9b77af359 100644 --- a/tests/acceptance/boot_linux_console.py +++ b/tests/acceptance/boot_linux_console.py @@ -34,7 +34,7 @@ class BootLinuxConsole(Test): failure_message='Kernel panic - not syncing') def exec_command_and_wait_for_pattern(self, command, success_message): - command += '\n' + command += '\r' self.vm.console_socket.sendall(command.encode()) wait_for_console_pattern(self, success_message)