| Message ID | 20191016145434.7007-1-drjones@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | s390x/cpumodel: Add missing visit_free | expand |
On 16.10.19 16:54, Andrew Jones wrote: > Beata Michalska noticed this missing visit_free() while reviewing > arm's implementation of qmp_query_cpu_model_expansion(), which is > modeled off this s390x implementation. Nice to see ARM support getting added. > > Signed-off-by: Andrew Jones <drjones@redhat.com> > --- > target/s390x/cpu_models.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c > index 009afc38b92d..7e92fb2e156d 100644 > --- a/target/s390x/cpu_models.c > +++ b/target/s390x/cpu_models.c > @@ -515,6 +515,7 @@ static void cpu_model_from_info(S390CPUModel *model, const CpuModelInfo *info, > visitor = qobject_input_visitor_new(info->props); > visit_start_struct(visitor, NULL, NULL, 0, errp); > if (*errp) { > + visit_free(visitor); > object_unref(obj); > return; > } > Right, thanks Reviewed-by: David Hildenbrand <david@redhat.com>
On Wed, 16 Oct 2019 16:54:34 +0200 Andrew Jones <drjones@redhat.com> wrote: > Beata Michalska noticed this missing visit_free() while reviewing > arm's implementation of qmp_query_cpu_model_expansion(), which is > modeled off this s390x implementation. > > Signed-off-by: Andrew Jones <drjones@redhat.com> > --- > target/s390x/cpu_models.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c > index 009afc38b92d..7e92fb2e156d 100644 > --- a/target/s390x/cpu_models.c > +++ b/target/s390x/cpu_models.c > @@ -515,6 +515,7 @@ static void cpu_model_from_info(S390CPUModel *model, const CpuModelInfo *info, > visitor = qobject_input_visitor_new(info->props); > visit_start_struct(visitor, NULL, NULL, 0, errp); > if (*errp) { > + visit_free(visitor); > object_unref(obj); > return; > } Thanks, applied.
diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c index 009afc38b92d..7e92fb2e156d 100644 --- a/target/s390x/cpu_models.c +++ b/target/s390x/cpu_models.c @@ -515,6 +515,7 @@ static void cpu_model_from_info(S390CPUModel *model, const CpuModelInfo *info, visitor = qobject_input_visitor_new(info->props); visit_start_struct(visitor, NULL, NULL, 0, errp); if (*errp) { + visit_free(visitor); object_unref(obj); return; }
Beata Michalska noticed this missing visit_free() while reviewing arm's implementation of qmp_query_cpu_model_expansion(), which is modeled off this s390x implementation. Signed-off-by: Andrew Jones <drjones@redhat.com> --- target/s390x/cpu_models.c | 1 + 1 file changed, 1 insertion(+)