| Message ID | 20191014085709.26812-2-stefanha@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | [PULL,1/2] trace: add --group=all to tracing.txt | expand |
Hi Stefan, On 10/14/19 10:57 AM, Stefan Hajnoczi wrote: > tracetool needs to know the group name ("all", "root", or a specific > subdirectory). Also remove the stdin redirection because tracetool.py > needs the path to the trace-events file. Update the documentation. > > Fixes: 2098c56a9bc5901e145fa5d4759f075808811685 > ("trace: move setting of group name into Makefiles") > Launchpad: https://bugs.launchpad.net/bugs/1844814 Sorry I didn't noticed that earlier, but on https://wiki.qemu.org/Contribute/SubmitAPatch#Write_a_meaningful_commit_message we recommend using the 'Buglink' tag. Not sure it's worth resending another pull request... > Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com> > Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> > Message-Id: <20191009135154.10970-1-stefanha@redhat.com> > --- > docs/devel/tracing.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/docs/devel/tracing.txt b/docs/devel/tracing.txt > index 8231bbf5d1..8c0376fefa 100644 > --- a/docs/devel/tracing.txt > +++ b/docs/devel/tracing.txt > @@ -317,7 +317,8 @@ probes: > --binary path/to/qemu-binary \ > --target-type system \ > --target-name x86_64 \ > - <trace-events-all >qemu.stp > + --group=all \ > + trace-events-all >qemu.stp > > To facilitate simple usage of systemtap where there merely needs to be printf > logging of certain probes, a helper script "qemu-trace-stap" is provided. >
On Mon, Oct 14, 2019 at 11:08:25AM +0200, Philippe Mathieu-Daudé wrote: > Hi Stefan, > > On 10/14/19 10:57 AM, Stefan Hajnoczi wrote: > > tracetool needs to know the group name ("all", "root", or a specific > > subdirectory). Also remove the stdin redirection because tracetool.py > > needs the path to the trace-events file. Update the documentation. > > > > Fixes: 2098c56a9bc5901e145fa5d4759f075808811685 > > ("trace: move setting of group name into Makefiles") > > Launchpad: https://bugs.launchpad.net/bugs/1844814 > > Sorry I didn't noticed that earlier, but on https://wiki.qemu.org/Contribute/SubmitAPatch#Write_a_meaningful_commit_message > we recommend using the 'Buglink' tag. > Not sure it's worth resending another pull request... Sure, it hasn't been merged yet so I can send a v2. Stefan
diff --git a/docs/devel/tracing.txt b/docs/devel/tracing.txt index 8231bbf5d1..8c0376fefa 100644 --- a/docs/devel/tracing.txt +++ b/docs/devel/tracing.txt @@ -317,7 +317,8 @@ probes: --binary path/to/qemu-binary \ --target-type system \ --target-name x86_64 \ - <trace-events-all >qemu.stp + --group=all \ + trace-events-all >qemu.stp To facilitate simple usage of systemtap where there merely needs to be printf logging of certain probes, a helper script "qemu-trace-stap" is provided.
tracetool needs to know the group name ("all", "root", or a specific subdirectory). Also remove the stdin redirection because tracetool.py needs the path to the trace-events file. Update the documentation. Fixes: 2098c56a9bc5901e145fa5d4759f075808811685 ("trace: move setting of group name into Makefiles") Launchpad: https://bugs.launchpad.net/bugs/1844814 Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Message-Id: <20191009135154.10970-1-stefanha@redhat.com> --- docs/devel/tracing.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)