| Message ID | 20191010121702.90142-1-77389867@qq.com |
|---|---|
| State | New |
| Headers | show |
| Series | tests: fix counting typo error | expand |
On Thu, Oct 10, 2019 at 08:17:02PM +0800, Tianjia Zhang wrote: > Instead of global variables, local variables should be incrementing, > This is a typo fix. > > Signed-off-by: Tianjia Zhang <77389867@qq.com> > --- > tests/test-rcu-list.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) CCing Paolo Bonzini, author of the RCU code. > > diff --git a/tests/test-rcu-list.c b/tests/test-rcu-list.c > index 6f076473e0..c0fc47ded4 100644 > --- a/tests/test-rcu-list.c > +++ b/tests/test-rcu-list.c > @@ -219,7 +219,7 @@ static void *rcu_q_updater(void *arg) > j++; > if (target_el == j) { > struct list_element *new_el = g_new(struct list_element, 1); > - n_nodes += n_nodes_local; > + n_nodes_local++; > TEST_LIST_INSERT_AFTER_RCU(el, new_el, entry); > break; > } > -- > 2.17.1 > >
Tianjia Zhang <77389867@qq.com> writes: > Instead of global variables, local variables should be incrementing, > This is a typo fix. Impact? The commit message calls it a "typo", which suggests there is none. The patch makes me suspect the bug is more serious than that. > > Signed-off-by: Tianjia Zhang <77389867@qq.com> > --- > tests/test-rcu-list.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/test-rcu-list.c b/tests/test-rcu-list.c > index 6f076473e0..c0fc47ded4 100644 > --- a/tests/test-rcu-list.c > +++ b/tests/test-rcu-list.c > @@ -219,7 +219,7 @@ static void *rcu_q_updater(void *arg) > j++; > if (target_el == j) { > struct list_element *new_el = g_new(struct list_element, 1); > - n_nodes += n_nodes_local; > + n_nodes_local++; > TEST_LIST_INSERT_AFTER_RCU(el, new_el, entry); > break; > }
diff --git a/tests/test-rcu-list.c b/tests/test-rcu-list.c index 6f076473e0..c0fc47ded4 100644 --- a/tests/test-rcu-list.c +++ b/tests/test-rcu-list.c @@ -219,7 +219,7 @@ static void *rcu_q_updater(void *arg) j++; if (target_el == j) { struct list_element *new_el = g_new(struct list_element, 1); - n_nodes += n_nodes_local; + n_nodes_local++; TEST_LIST_INSERT_AFTER_RCU(el, new_el, entry); break; }
Instead of global variables, local variables should be incrementing, This is a typo fix. Signed-off-by: Tianjia Zhang <77389867@qq.com> --- tests/test-rcu-list.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)