| Message ID | 20191004125641.24383-1-stefanha@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | audio: add -audiodev pa,in|out.latency= to documentation | expand |
Hi On Fri, Oct 4, 2019 at 4:57 PM Stefan Hajnoczi <stefanha@redhat.com> wrote: > > The "latency" parameter wasn't covered by the documentation. > > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> > --- > Hi Gerd, > You asked me to resend this patch because there was a conflict. I have > rebased it onto qemu.git/master (4f59102571fc). > > qemu-options.hx | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/qemu-options.hx b/qemu-options.hx > index 2a04ca6ac5..5c27c57273 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -470,6 +470,7 @@ DEF("audiodev", HAS_ARG, QEMU_OPTION_audiodev, > "-audiodev pa,id=id[,prop[=value][,...]]\n" > " server= PulseAudio server address\n" > " in|out.name= source/sink device name\n" > + " in|out.latency= desired latency in microseconds\n" > #endif > #ifdef CONFIG_AUDIO_SDL > "-audiodev sdl,id=id[,prop[=value][,...]]\n" > @@ -630,6 +631,10 @@ Sets the PulseAudio @var{server} to connect to. > @item in|out.name=@var{sink} > Use the specified source/sink for recording/playback. > > +@item in|out.latency=@var{usecs} > +Desired latency in microseconds. The PulseAudio server will try to honor this > +value but actual latencies may be lower or higher. default is 15ms according to f6142777659f2e7ad143f2850f1f036f899f475f, might be worth to document. otherwise, looks good: Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> > + > @end table > > @item -audiodev sdl,id=@var{id}[,@var{prop}[=@var{value}][,...]] > -- > 2.21.0 > >
On Fri, Oct 04, 2019 at 01:56:41PM +0100, Stefan Hajnoczi wrote: > The "latency" parameter wasn't covered by the documentation. > > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> > --- > Hi Gerd, > You asked me to resend this patch because there was a conflict. I have > rebased it onto qemu.git/master (4f59102571fc). > > qemu-options.hx | 5 +++++ > 1 file changed, 5 insertions(+) Ping? > diff --git a/qemu-options.hx b/qemu-options.hx > index 2a04ca6ac5..5c27c57273 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -470,6 +470,7 @@ DEF("audiodev", HAS_ARG, QEMU_OPTION_audiodev, > "-audiodev pa,id=id[,prop[=value][,...]]\n" > " server= PulseAudio server address\n" > " in|out.name= source/sink device name\n" > + " in|out.latency= desired latency in microseconds\n" > #endif > #ifdef CONFIG_AUDIO_SDL > "-audiodev sdl,id=id[,prop[=value][,...]]\n" > @@ -630,6 +631,10 @@ Sets the PulseAudio @var{server} to connect to. > @item in|out.name=@var{sink} > Use the specified source/sink for recording/playback. > > +@item in|out.latency=@var{usecs} > +Desired latency in microseconds. The PulseAudio server will try to honor this > +value but actual latencies may be lower or higher. > + > @end table > > @item -audiodev sdl,id=@var{id}[,@var{prop}[=@var{value}][,...]] > -- > 2.21.0 > >
diff --git a/qemu-options.hx b/qemu-options.hx index 2a04ca6ac5..5c27c57273 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -470,6 +470,7 @@ DEF("audiodev", HAS_ARG, QEMU_OPTION_audiodev, "-audiodev pa,id=id[,prop[=value][,...]]\n" " server= PulseAudio server address\n" " in|out.name= source/sink device name\n" + " in|out.latency= desired latency in microseconds\n" #endif #ifdef CONFIG_AUDIO_SDL "-audiodev sdl,id=id[,prop[=value][,...]]\n" @@ -630,6 +631,10 @@ Sets the PulseAudio @var{server} to connect to. @item in|out.name=@var{sink} Use the specified source/sink for recording/playback. +@item in|out.latency=@var{usecs} +Desired latency in microseconds. The PulseAudio server will try to honor this +value but actual latencies may be lower or higher. + @end table @item -audiodev sdl,id=@var{id}[,@var{prop}[=@var{value}][,...]]
The "latency" parameter wasn't covered by the documentation. Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> --- Hi Gerd, You asked me to resend this patch because there was a conflict. I have rebased it onto qemu.git/master (4f59102571fc). qemu-options.hx | 5 +++++ 1 file changed, 5 insertions(+)