Message ID | 20190925174400.8578-1-stefanha@redhat.com |
---|---|
State | New |
Headers | show |
Patchew URL: https://patchew.org/QEMU/20190925174400.8578-1-stefanha@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #! /bin/bash export ARCH=x86_64 make docker-image-fedora V=1 NETWORK=1 time make docker-test-mingw@fedora J=14 NETWORK=1 === TEST SCRIPT END === CC authz/list.o CC authz/listfile.o /tmp/qemu-test/src/util/iov.c: In function 'qemu_iovec_init_extended': /tmp/qemu-test/src/util/iov.c:451:9: error: 'mid_iov' may be used uninitialized in this function [-Werror=maybe-uninitialized] memcpy(p, mid_iov, mid_niov * sizeof(*p)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors The full log is available at http://patchew.org/logs/20190925174400.8578-1-stefanha@redhat.com/testing.docker-mingw@fedora/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
26.09.2019 9:16, no-reply@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20190925174400.8578-1-stefanha@redhat.com/ > > > > Hi, > > This series failed the docker-mingw@fedora build test. Please find the testing commands and > their output below. If you have Docker installed, you can probably reproduce it > locally. > > === TEST SCRIPT BEGIN === > #! /bin/bash > export ARCH=x86_64 > make docker-image-fedora V=1 NETWORK=1 > time make docker-test-mingw@fedora J=14 NETWORK=1 > === TEST SCRIPT END === > > CC authz/list.o > CC authz/listfile.o > /tmp/qemu-test/src/util/iov.c: In function 'qemu_iovec_init_extended': > /tmp/qemu-test/src/util/iov.c:451:9: error: 'mid_iov' may be used uninitialized in this function [-Werror=maybe-uninitialized] > memcpy(p, mid_iov, mid_niov * sizeof(*p)); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > > > The full log is available at > http://patchew.org/logs/20190925174400.8578-1-stefanha@redhat.com/testing.docker-mingw@fedora/?type=message. > --- > Email generated automatically by Patchew [https://patchew.org/]. > Please send your feedback to patchew-devel@redhat.com > Actually it's obvious that it is initialized here: We go here only if mid_niov, which may be set only in "if (mid_len)", and mid_iov is set in same "if (mid_len)". My clang don't warn. Still, we may just initialize mid_iov to NULL and don't care.
On Wed, 25 Sep 2019 at 18:44, Stefan Hajnoczi <stefanha@redhat.com> wrote: > > The following changes since commit 240ab11fb72049d6373cbbec8d788f8e411a00bc: > > Merge remote-tracking branch 'remotes/aperard/tags/pull-xen-20190924' into staging (2019-09-24 15:36:31 +0100) > > are available in the Git repository at: > > https://github.com/stefanha/qemu.git tags/block-pull-request > > for you to fetch changes up to f9a7e3698a737ee75a7b0af34203303df982550f: > > virtio-blk: schedule virtio_notify_config to run on main context (2019-09-25 18:06:36 +0100) > > ---------------------------------------------------------------- > Pull request > > ---------------------------------------------------------------- Hi; I'm dropping this pullreq as it makes one of the patchew build configs fail to compile. thanks -- PMM