Message ID | 20190916135806.1269-20-david@redhat.com |
---|---|
State | New |
Headers | show |
Series | s390x/tcg: mem_helper: Fault-safe handling | expand |
On 9/16/19 9:57 AM, David Hildenbrand wrote: > The last remaining bit for MVC is handling destructive overlaps in a > fault-safe way. > > Signed-off-by: David Hildenbrand <david@redhat.com> > --- > target/s390x/mem_helper.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 6b85f44e22..abb9d4d70c 100644 --- a/target/s390x/mem_helper.c +++ b/target/s390x/mem_helper.c @@ -432,8 +432,9 @@ static uint32_t do_helper_mvc(CPUS390XState *env, uint32_t l, uint64_t dest, access_memmove(env, &desta, &srca, ra); } else { for (i = 0; i < l; i++) { - uint8_t x = cpu_ldub_data_ra(env, src + i, ra); - cpu_stb_data_ra(env, dest + i, x, ra); + uint8_t byte = access_get_byte(env, &srca, i, ra); + + access_set_byte(env, &desta, i, byte, ra); } }
The last remaining bit for MVC is handling destructive overlaps in a fault-safe way. Signed-off-by: David Hildenbrand <david@redhat.com> --- target/s390x/mem_helper.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)