From patchwork Fri Jul 19 21:03:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 1134289 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="MQ5wekzR"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45r3S81sCPz9s4Y for ; Sat, 20 Jul 2019 07:05:28 +1000 (AEST) Received: from localhost ([::1]:48184 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hoa4D-0001S7-L3 for incoming@patchwork.ozlabs.org; Fri, 19 Jul 2019 17:05:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55036) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hoa3P-0007OC-AJ for qemu-devel@nongnu.org; Fri, 19 Jul 2019 17:04:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hoa3G-0005Qb-8S for qemu-devel@nongnu.org; Fri, 19 Jul 2019 17:04:31 -0400 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]:43905) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hoa34-0005A3-Ku for qemu-devel@nongnu.org; Fri, 19 Jul 2019 17:04:14 -0400 Received: by mail-pg1-x542.google.com with SMTP id f25so14961722pgv.10 for ; Fri, 19 Jul 2019 14:03:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=bac4HlG+GhgCvK1k1tbO834GKZB7uCzaXoyKitScQ6E=; b=MQ5wekzRq98FXeVHb4/hyGN9D0wgON4UDJTqCRfGtYpW5UEnZlAcwUqKg4CD16QK2N PQjlBbvJNM9sLRU9SPtLQdRBkIg+yJT4NkZX+eiT1vHNywNl+ZW/P+k0MzRyG1j1GpNa N9MuUyDSUN4m2fExZTq3zJP/0NsfdC/tOm4SNo8ZZ00iodV1pQqQHKnXCizqpfAHi17F E8TiILrOkQmf7r5CaTz+svhMJomY6G+YSaKXOJ1I2S35BnJOh4K1xuB62ink1xr3/CSX CFuJrS4hWjnfJi6SK++OjytYiF9+TK5utwDr0CBUALf+4P5QWSogVl3Vpd6Y8vS0jg42 FrDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=bac4HlG+GhgCvK1k1tbO834GKZB7uCzaXoyKitScQ6E=; b=UWPvSQgxOzZcpyqigru8hywjBzn+f0s68opqxRl04ZpYLmLYEzh51HcWTXXYDkXce2 fpv+zakU1mOVbek9FBAP8oC77MWLBFMdQtmnF4qjF+59gG3NKNUdqUxBXJDjM3Vllbre hirIGR6a/jZ/zLQKDV/q3mhU9b98QUINdS2CQ09bWWxT9ZHWrZl1RoU/07p2mOy1jcAS DuaKPBYwLCqDU+CWY3i4s7BsX2Aw8VjTVx4eiGtnCu/17irLll4f1aC4t+dQdcnT0CaS MvYfRKqUkKfNAqb6bhSoxBpOSZFoOnZhKxDPzyTm5y0BebozYz5uDOSKs6oj9X4GwY7P QDYw== X-Gm-Message-State: APjAAAUCaHwucP2k/+JptNbwtNk+igEIzi9WnvjN1ducaWvQ/C0r82IG lVUf2U6wlw73Ai0U2rLgUGvW1vB6eno= X-Google-Smtp-Source: APXvYqyjY2XHJb+GJ0tLIh5xX6Mnl0keQXeGX7khVW/ZiztG0/aidYWPHK3OAE3vZsfIE97+u46+/Q== X-Received: by 2002:a65:64c6:: with SMTP id t6mr57167694pgv.323.1563570224614; Fri, 19 Jul 2019 14:03:44 -0700 (PDT) Received: from localhost.localdomain (97-126-117-207.tukw.qwest.net. [97.126.117.207]) by smtp.gmail.com with ESMTPSA id i6sm32724751pgi.40.2019.07.19.14.03.43 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 19 Jul 2019 14:03:44 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 19 Jul 2019 14:03:16 -0700 Message-Id: <20190719210326.15466-15-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190719210326.15466-1-richard.henderson@linaro.org> References: <20190719210326.15466-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::542 Subject: [Qemu-devel] [PATCH for-4.2 14/24] target/arm: Simplify tlb_force_broadcast alternatives X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, beata.michalska@linaro.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Rather than call to a separate function and re-compute any parameters for the flush, simply use the correct flush function directly. Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée --- target/arm/helper.c | 52 +++++++++++++++++++++------------------------ 1 file changed, 24 insertions(+), 28 deletions(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index 7adbf51479..2b95fc763f 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -626,56 +626,54 @@ static void tlbiall_write(CPUARMState *env, const ARMCPRegInfo *ri, uint64_t value) { /* Invalidate all (TLBIALL) */ - ARMCPU *cpu = env_archcpu(env); + CPUState *cs = env_cpu(env); if (tlb_force_broadcast(env)) { - tlbiall_is_write(env, NULL, value); - return; + tlb_flush_all_cpus_synced(cs); + } else { + tlb_flush(cs); } - - tlb_flush(CPU(cpu)); } static void tlbimva_write(CPUARMState *env, const ARMCPRegInfo *ri, uint64_t value) { /* Invalidate single TLB entry by MVA and ASID (TLBIMVA) */ - ARMCPU *cpu = env_archcpu(env); + CPUState *cs = env_cpu(env); + value &= TARGET_PAGE_MASK; if (tlb_force_broadcast(env)) { - tlbimva_is_write(env, NULL, value); - return; + tlb_flush_page_all_cpus_synced(cs, value); + } else { + tlb_flush_page(cs, value); } - - tlb_flush_page(CPU(cpu), value & TARGET_PAGE_MASK); } static void tlbiasid_write(CPUARMState *env, const ARMCPRegInfo *ri, uint64_t value) { /* Invalidate by ASID (TLBIASID) */ - ARMCPU *cpu = env_archcpu(env); + CPUState *cs = env_cpu(env); if (tlb_force_broadcast(env)) { - tlbiasid_is_write(env, NULL, value); - return; + tlb_flush_all_cpus_synced(cs); + } else { + tlb_flush(cs); } - - tlb_flush(CPU(cpu)); } static void tlbimvaa_write(CPUARMState *env, const ARMCPRegInfo *ri, uint64_t value) { /* Invalidate single entry by MVA, all ASIDs (TLBIMVAA) */ - ARMCPU *cpu = env_archcpu(env); + CPUState *cs = env_cpu(env); + value &= TARGET_PAGE_MASK; if (tlb_force_broadcast(env)) { - tlbimvaa_is_write(env, NULL, value); - return; + tlb_flush_page_all_cpus_synced(cs, value); + } else { + tlb_flush_page(cs, value); } - - tlb_flush_page(CPU(cpu), value & TARGET_PAGE_MASK); } static void tlbiall_nsnh_write(CPUARMState *env, const ARMCPRegInfo *ri, @@ -3926,11 +3924,10 @@ static void tlbi_aa64_vmalle1_write(CPUARMState *env, const ARMCPRegInfo *ri, int mask = vae1_tlbmask(env); if (tlb_force_broadcast(env)) { - tlbi_aa64_vmalle1is_write(env, NULL, value); - return; + tlb_flush_by_mmuidx_all_cpus_synced(cs, mask); + } else { + tlb_flush_by_mmuidx(cs, mask); } - - tlb_flush_by_mmuidx(cs, mask); } static int vmalle1_tlbmask(CPUARMState *env) @@ -4052,11 +4049,10 @@ static void tlbi_aa64_vae1_write(CPUARMState *env, const ARMCPRegInfo *ri, uint64_t pageaddr = sextract64(value << 12, 0, 56); if (tlb_force_broadcast(env)) { - tlbi_aa64_vae1is_write(env, NULL, value); - return; + tlb_flush_page_by_mmuidx_all_cpus_synced(cs, pageaddr, mask); + } else { + tlb_flush_page_by_mmuidx(cs, pageaddr, mask); } - - tlb_flush_page_by_mmuidx(cs, pageaddr, mask); } static void tlbi_aa64_vae2is_write(CPUARMState *env, const ARMCPRegInfo *ri,