| Message ID | 20190719133530.28688-3-mehta.aaru20@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for io_uring | expand |
On Fri, Jul 19, 2019 at 07:05:18PM +0530, Aarushi Mehta wrote: > Only enumerates option for devices that support it > > Signed-off-by: Aarushi Mehta <mehta.aaru20@gmail.com> > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> > --- > qapi/block-core.json | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 0d43d4f37c..0a3d4ae7d2 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -2792,11 +2792,13 @@ > # > # @threads: Use qemu's thread pool > # @native: Use native AIO backend (only Linux and Windows) > +# @io_uring: Use linux io_uring (since 4.1) Please change this to 4.2. QEMU 4.1 is frozen prior to the upcoming release and new features aren't being merged. Stefan
On 7/19/19 8:35 AM, Aarushi Mehta wrote: > Only enumerates option for devices that support it > > Signed-off-by: Aarushi Mehta <mehta.aaru20@gmail.com> > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> > --- > qapi/block-core.json | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 0d43d4f37c..0a3d4ae7d2 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -2792,11 +2792,13 @@ > # > # @threads: Use qemu's thread pool > # @native: Use native AIO backend (only Linux and Windows) > +# @io_uring: Use linux io_uring (since 4.1) I know you explained in an earlier revision why you chose 'io_uring' instead of the more typical QAPI spelling of 'io-uring' (namely, it matches the Linux kernel feature spelling). That explanation belongs in the commit message, rather than just the mailing list archives. > # > # Since: 2.9 > ## > { 'enum': 'BlockdevAioOptions', > - 'data': [ 'threads', 'native' ] } > + 'data': [ 'threads', 'native', > + { 'name': 'io_uring', 'if': 'defined(CONFIG_LINUX_IO_URING)' } ] } > > ## > # @BlockdevCacheOptions: >
diff --git a/qapi/block-core.json b/qapi/block-core.json index 0d43d4f37c..0a3d4ae7d2 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -2792,11 +2792,13 @@ # # @threads: Use qemu's thread pool # @native: Use native AIO backend (only Linux and Windows) +# @io_uring: Use linux io_uring (since 4.1) # # Since: 2.9 ## { 'enum': 'BlockdevAioOptions', - 'data': [ 'threads', 'native' ] } + 'data': [ 'threads', 'native', + { 'name': 'io_uring', 'if': 'defined(CONFIG_LINUX_IO_URING)' } ] } ## # @BlockdevCacheOptions: