| Message ID | 20190708125433.16927-3-cohuck@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | s390x: fallthrough annotations | expand |
Am 08.07.2019 um 14:54 schrieb Cornelia Huck: > ...so that the compiler properly recognizes it. > > Reported-by: Stefan Weil <sw@weilnetz.de> > Fixes: f180da83c039 ("s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO") > Signed-off-by: Cornelia Huck <cohuck@redhat.com> > --- > target/s390x/translate_vx.inc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/s390x/translate_vx.inc.c b/target/s390x/translate_vx.inc.c > index 7b1d31cba5cf..41d5cf869f94 100644 > --- a/target/s390x/translate_vx.inc.c > +++ b/target/s390x/translate_vx.inc.c > @@ -577,8 +577,8 @@ static DisasJumpType op_vllez(DisasContext *s, DisasOps *o) > enr = 0; > break; > } > - default: > /* fallthrough */ > + default: > gen_program_exception(s, PGM_SPECIFICATION); > return DISAS_NORETURN; > } Reviewed-by: Stefan Weil <sw@weilnetz.de> Thanks, Stefan
On 7/8/19 2:54 PM, Cornelia Huck wrote: > ...so that the compiler properly recognizes it. > > Reported-by: Stefan Weil <sw@weilnetz.de> > Fixes: f180da83c039 ("s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO") > Signed-off-by: Cornelia Huck <cohuck@redhat.com> > --- > target/s390x/translate_vx.inc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/s390x/translate_vx.inc.c b/target/s390x/translate_vx.inc.c > index 7b1d31cba5cf..41d5cf869f94 100644 > --- a/target/s390x/translate_vx.inc.c > +++ b/target/s390x/translate_vx.inc.c > @@ -577,8 +577,8 @@ static DisasJumpType op_vllez(DisasContext *s, DisasOps *o) > enr = 0; > break; > } > - default: > /* fallthrough */ > + default: Haha :) Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > gen_program_exception(s, PGM_SPECIFICATION); > return DISAS_NORETURN; > } >
On Tue, 16 Jul 2019 17:22:59 +0200 Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > On 7/8/19 2:54 PM, Cornelia Huck wrote: > > ...so that the compiler properly recognizes it. > > > > Reported-by: Stefan Weil <sw@weilnetz.de> > > Fixes: f180da83c039 ("s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO") > > Signed-off-by: Cornelia Huck <cohuck@redhat.com> > > --- > > target/s390x/translate_vx.inc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/target/s390x/translate_vx.inc.c b/target/s390x/translate_vx.inc.c > > index 7b1d31cba5cf..41d5cf869f94 100644 > > --- a/target/s390x/translate_vx.inc.c > > +++ b/target/s390x/translate_vx.inc.c > > @@ -577,8 +577,8 @@ static DisasJumpType op_vllez(DisasContext *s, DisasOps *o) > > enr = 0; > > break; > > } > > - default: > > /* fallthrough */ > > + default: > > Haha :) > > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Thanks, but this is already merged :) > > > gen_program_exception(s, PGM_SPECIFICATION); > > return DISAS_NORETURN; > > } > >
diff --git a/target/s390x/translate_vx.inc.c b/target/s390x/translate_vx.inc.c index 7b1d31cba5cf..41d5cf869f94 100644 --- a/target/s390x/translate_vx.inc.c +++ b/target/s390x/translate_vx.inc.c @@ -577,8 +577,8 @@ static DisasJumpType op_vllez(DisasContext *s, DisasOps *o) enr = 0; break; } - default: /* fallthrough */ + default: gen_program_exception(s, PGM_SPECIFICATION); return DISAS_NORETURN; }
...so that the compiler properly recognizes it. Reported-by: Stefan Weil <sw@weilnetz.de> Fixes: f180da83c039 ("s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO") Signed-off-by: Cornelia Huck <cohuck@redhat.com> --- target/s390x/translate_vx.inc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)