Message ID | 20190705201631.26266-5-jsnow@redhat.com |
---|---|
State | New |
Headers | show |
Series | bitmaps: introduce 'bitmap' sync mode | expand |
On 05.07.19 22:16, John Snow wrote: > Depending on what a user is trying to accomplish, there might be a few > bitmap cleanup actions that occur when an operation is finished that > could be useful. > > I am proposing three: > - NEVER: The bitmap is never synchronized against what was copied. > - ALWAYS: The bitmap is always synchronized, even on failures. > - ON-SUCCESS: The bitmap is synchronized only on success. > > The existing incremental backup modes use 'on-success' semantics, > so add just that one for right now. > > Signed-off-by: John Snow <jsnow@redhat.com> > --- > qapi/block-core.json | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) Reviewed-by: Max Reitz <mreitz@redhat.com>
diff --git a/qapi/block-core.json b/qapi/block-core.json index 0af3866015..0c853d00bd 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -1134,6 +1134,20 @@ { 'enum': 'MirrorSyncMode', 'data': ['top', 'full', 'none', 'incremental'] } +## +# @BitmapSyncMode: +# +# An enumeration of possible behaviors for the synchronization of a bitmap +# when used for data copy operations. +# +# @on-success: The bitmap is only synced when the operation is successful. +# This is the behavior always used for 'INCREMENTAL' backups. +# +# Since: 4.2 +## +{ 'enum': 'BitmapSyncMode', + 'data': ['on-success'] } + ## # @MirrorCopyMode: #
Depending on what a user is trying to accomplish, there might be a few bitmap cleanup actions that occur when an operation is finished that could be useful. I am proposing three: - NEVER: The bitmap is never synchronized against what was copied. - ALWAYS: The bitmap is always synchronized, even on failures. - ON-SUCCESS: The bitmap is synchronized only on success. The existing incremental backup modes use 'on-success' semantics, so add just that one for right now. Signed-off-by: John Snow <jsnow@redhat.com> --- qapi/block-core.json | 14 ++++++++++++++ 1 file changed, 14 insertions(+)