From patchwork Fri Jun 28 09:49:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prasad Pandit X-Patchwork-Id: 1124082 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45ZsVZ2gpVz9s3l for ; Fri, 28 Jun 2019 19:51:50 +1000 (AEST) Received: from localhost ([::1]:58342 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgnXo-0003RM-E0 for incoming@patchwork.ozlabs.org; Fri, 28 Jun 2019 05:51:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50645) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgnXU-0003OQ-5p for qemu-devel@nongnu.org; Fri, 28 Jun 2019 05:51:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgnXT-0000BW-0D for qemu-devel@nongnu.org; Fri, 28 Jun 2019 05:51:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9136) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hgnXS-00009S-Je for qemu-devel@nongnu.org; Fri, 28 Jun 2019 05:51:26 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9FE712F8BEC; Fri, 28 Jun 2019 09:51:24 +0000 (UTC) Received: from localhost.localdomain (ovpn-116-191.sin2.redhat.com [10.67.116.191]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 598E05B693; Fri, 28 Jun 2019 09:51:18 +0000 (UTC) From: P J P To: Qemu Developers Date: Fri, 28 Jun 2019 15:19:01 +0530 Message-Id: <20190628094901.13347-1-ppandit@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 28 Jun 2019 09:51:24 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] qemu-bridge-helper: restrict bridge name to IFNAMSIZ X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Riccardo Schirone , "Daniel P . Berrange" , Prasad J Pandit Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Prasad J Pandit The interface names in qemu-bridge-helper are defined to be of size IFNAMSIZ(=16), including the terminating null('\0') byte. The same is applied to interface names read from 'bridge.conf' file to form ACLs rules. If user supplied '--br=bridge' name is not restricted to the same length, it could lead to ACL bypass issue. Restrict bridge name to IFNAMSIZ, including null byte. Reported-by: Riccardo Schirone Signed-off-by: Prasad J Pandit --- qemu-bridge-helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-bridge-helper.c b/qemu-bridge-helper.c index f9940deefd..2eca8c5cc4 100644 --- a/qemu-bridge-helper.c +++ b/qemu-bridge-helper.c @@ -246,7 +246,7 @@ int main(int argc, char **argv) if (strcmp(argv[index], "--use-vnet") == 0) { use_vnet = 1; } else if (strncmp(argv[index], "--br=", 5) == 0) { - bridge = &argv[index][5]; + bridge = strndup(&argv[index][5], IFNAMSIZ - 1); } else if (strncmp(argv[index], "--fd=", 5) == 0) { unixfd = atoi(&argv[index][5]); } else {