diff mbox series

gdbstub: print message on startup as gdbserver

Message ID 20190619145654.118068-1-ldurfina@tachyum.com
State New
Headers show
Series gdbstub: print message on startup as gdbserver | expand

Commit Message

lukas.durfina@gmail.com June 19, 2019, 2:56 p.m. UTC
From: Lukas Durfina <ldurfina@tachyum.com>

It helps to test gdb running qemu instead of a gdbserver.
It prints the same message as the gdbserver on startup.

Signed-off-by: Lukas Durfina <ldurfina@tachyum.com>
---
 gdbstub.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Alex Bennée June 19, 2019, 5:01 p.m. UTC | #1
lukas.durfina@gmail.com writes:

> From: Lukas Durfina <ldurfina@tachyum.com>
>
> It helps to test gdb running qemu instead of a gdbserver.
> It prints the same message as the gdbserver on startup.
>
> Signed-off-by: Lukas Durfina <ldurfina@tachyum.com>
> ---
>  gdbstub.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index 8618e34311..9ad9929968 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -3109,6 +3109,7 @@ int gdbserver_start(int port)
>      gdbserver_fd = gdbserver_open(port);
>      if (gdbserver_fd < 0)
>          return -1;
> +    printf("Listening on port %d\n", port);

Not really - we don't arbitrarily output stuff on stdout. In fact the
best way to track what gdbserver is doing is to use the built-in trace
points:

  $QEMU -d trace:gdb\* $QEMU_ARGS

For system emulation from the console you can run:

  (qemu) info chardev

which will report the state of the gdb connection:

  gdb: filename=disconnected:tcp:0.0.0.0:1234,server

>      /* accept connections */
>      if (!gdb_accept()) {
>          close(gdbserver_fd);


--
Alex Bennée
diff mbox series

Patch

diff --git a/gdbstub.c b/gdbstub.c
index 8618e34311..9ad9929968 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -3109,6 +3109,7 @@  int gdbserver_start(int port)
     gdbserver_fd = gdbserver_open(port);
     if (gdbserver_fd < 0)
         return -1;
+    printf("Listening on port %d\n", port);
     /* accept connections */
     if (!gdb_accept()) {
         close(gdbserver_fd);