From patchwork Thu Jun 6 09:25:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Klaus Birkelund X-Patchwork-Id: 1110977 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=birkelund.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45KKzV6qg1z9s4Y for ; Thu, 6 Jun 2019 19:26:29 +1000 (AEST) Received: from localhost ([127.0.0.1]:57082 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYofC-0006sg-T3 for incoming@patchwork.ozlabs.org; Thu, 06 Jun 2019 05:26:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38192) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYoeb-0006qa-F4 for qemu-devel@nongnu.org; Thu, 06 Jun 2019 05:25:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYoea-0003fs-Kw for qemu-devel@nongnu.org; Thu, 06 Jun 2019 05:25:49 -0400 Received: from charlie.dont.surf ([128.199.63.193]:42578) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hYoeY-0003YA-HH; Thu, 06 Jun 2019 05:25:46 -0400 Received: from apples.localdomain (soho-cph.cust-cnex.dsd101.net [194.62.216.132]) by charlie.dont.surf (Postfix) with ESMTPSA id F1191BF724; Thu, 6 Jun 2019 09:25:43 +0000 (UTC) From: Klaus Birkelund Jensen To: qemu-block@nongnu.org Date: Thu, 6 Jun 2019 11:25:30 +0200 Message-Id: <20190606092530.14206-1-klaus@birkelund.eu> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 128.199.63.193 Subject: [Qemu-devel] [PATCH] nvme: do not advertise support for unsupported arbitration mechanism X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Keith Busch , Kevin Wolf , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" The device mistakenly reports that the Weighted Round Robin with Urgent Priority Class arbitration mechanism is supported. It is not. Signed-off-by: Klaus Birkelund Jensen Acked-by: Maxim Levitsky --- hw/block/nvme.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 30e50f7a3853..415b4641d6b4 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -1383,7 +1383,6 @@ static void nvme_realize(PCIDevice *pci_dev, Error **errp) n->bar.cap = 0; NVME_CAP_SET_MQES(n->bar.cap, 0x7ff); NVME_CAP_SET_CQR(n->bar.cap, 1); - NVME_CAP_SET_AMS(n->bar.cap, 1); NVME_CAP_SET_TO(n->bar.cap, 0xf); NVME_CAP_SET_CSS(n->bar.cap, 1); NVME_CAP_SET_MPSMAX(n->bar.cap, 4);