diff mbox series

iotests: restrict 254 to support only qcow2

Message ID 20190605155405.104384-1-vsementsov@virtuozzo.com
State New
Headers show
Series iotests: restrict 254 to support only qcow2 | expand

Commit Message

Vladimir Sementsov-Ogievskiy June 5, 2019, 3:54 p.m. UTC
Test fails at least for qcow, because of different cluster sizes in
base and top (and therefore different granularities of bitmaps we are
trying to merge).

The test aim is to check block-dirty-bitmap-merge between different
nodes functionality, no needs to check all formats. So, let's just drop
support for anything except qcow2.

Reported-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 tests/qemu-iotests/254 | 2 ++
 1 file changed, 2 insertions(+)

Comments

Max Reitz June 5, 2019, 4:12 p.m. UTC | #1
On 05.06.19 17:54, Vladimir Sementsov-Ogievskiy wrote:
> Test fails at least for qcow, because of different cluster sizes in
> base and top (and therefore different granularities of bitmaps we are
> trying to merge).
> 
> The test aim is to check block-dirty-bitmap-merge between different
> nodes functionality, no needs to check all formats. So, let's just drop
> support for anything except qcow2.
> 
> Reported-by: Max Reitz <mreitz@redhat.com>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>  tests/qemu-iotests/254 | 2 ++
>  1 file changed, 2 insertions(+)

Thanks, applied to my block branch:

https://git.xanclic.moe/XanClic/qemu/commits/branch/block

Max
diff mbox series

Patch

diff --git a/tests/qemu-iotests/254 b/tests/qemu-iotests/254
index 33cb80a512..8edba91c5d 100755
--- a/tests/qemu-iotests/254
+++ b/tests/qemu-iotests/254
@@ -21,6 +21,8 @@ 
 import iotests
 from iotests import qemu_img_create, file_path, log
 
+iotests.verify_image_format(supported_fmts=['qcow2'])
+
 disk, top = file_path('disk', 'top')
 size = 1024 * 1024