[v1,17/26] tests/vm: run test builds on snapshot

Message ID	20190530101603.22254-18-alex.bennee@linaro.org
State	New
Headers	show Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> From: =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org> To: qemu-devel@nongnu.org Date: Thu, 30 May 2019 11:15:54 +0100 Message-Id: <20190530101603.22254-18-alex.bennee@linaro.org> In-Reply-To: <20190530101603.22254-1-alex.bennee@linaro.org> References: <20190530101603.22254-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH v1 17/26] tests/vm: run test builds on snapshot Precedence: list Cc: Fam Zheng <fam@euphon.net>, Thomas Huth <thuth@redhat.com>, Ed Maste <emaste@freebsd.org>, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org> Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>
Series	testing/next queue (iotests, docker, tests/vm) \| expand [v1,00/26] testing/next queue (iotests, docker, tests/vm) [v1,01/26] editorconfig: add setting for shell scripts [v1,02/26] qemu-io-cmds: use clock_gettime for benchmarking [v1,03/26] tests: Run the iotests during "make check" again [v1,04/26] tests/docker: Update the Fedora image to Fedora 30 [v1,05/26] tests/docker: Update the Fedora cross compile images to 30 [v1,06/26] tests/docker: Update the Ubuntu image to 19.04 [v1,07/26] .travis.yml: bump gcc sanitiser job to gcc-9 [v1,08/26] .travis.yml: add clang ubsan job [v1,09/26] tests/vm: Use python configured on build [v1,10/26] tests/vm: Port basevm to Python 3 [v1,11/26] tests/vm: Fix build-centos docker-based tests run [v1,12/26] tests/vm: Add missing variables on help [v1,13/26] scripts: use git archive in archive-source [v1,14/26] tests/vm: python3 fixes [v1,15/26] tests/vm: send proxy environment variables over ssh [v1,16/26] tests/vm: use ssh with pty unconditionally [v1,17/26] tests/vm: run test builds on snapshot [v1,18/26] tests/vm: proper guest shutdown [v1,19/26] tests/vm: add vm-boot-{ssh, serial}-<guest> targets [v1,20/26] tests/vm: add DEBUG=1 to help text [v1,21/26] tests/vm: serial console support helpers [v1,22/26] tests/vm: openbsd autoinstall, using serial console [v1,23/26] tests/vm: freebsd autoinstall, using serial console [v1,24/26] tests/vm: netbsd autoinstall, using serial console [v1,25/26] tests/vm: fedora autoinstall, using serial console [v1,26/26] tests/vm: ubuntu.i386: apt proxy setup

Message ID

20190530101603.22254-18-alex.bennee@linaro.org

State

New

Headers

From: =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Date: Thu, 30 May 2019 11:15:54 +0100
Message-Id: <20190530101603.22254-18-alex.bennee@linaro.org>
In-Reply-To: <20190530101603.22254-1-alex.bennee@linaro.org>
References: <20190530101603.22254-1-alex.bennee@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: [Qemu-devel] [PATCH v1 17/26] tests/vm: run test builds on snapshot
Precedence: list
Cc: Fam Zheng <fam@euphon.net>, Thomas Huth <thuth@redhat.com>, Ed Maste
	<emaste@freebsd.org>, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?=
	<philmd@redhat.com>, 	Gerd Hoffmann <kraxel@redhat.com>,
	=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>
Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org
Sender: "Qemu-devel"
	<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>

Series

testing/next queue (iotests, docker, tests/vm) | expand

Commit Message

Alex Bennée May 30, 2019, 10:15 a.m. UTC

From: Gerd Hoffmann <kraxel@redhat.com>

The build script doesn't shutdown the guest VMs properly,
which results in filesystem corruption and guest boot
failures sooner or later.

Use the --snapshot to run builds on a snapshot,
That way killing the VM doesn't corrupt the base image.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Tested-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Ed Maste <emaste@freebsd.org>
Message-Id: <20190520124716.30472-6-kraxel@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 tests/vm/Makefile.include | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include
index c59411bee01..276b870216c 100644
--- a/tests/vm/Makefile.include
+++ b/tests/vm/Makefile.include
@@ -57,6 +57,7 @@  vm-build-%: $(IMAGES_DIR)/%.img
 		$(if $(V),--verbose) \
 		--image "$<" \
 		$(if $(BUILD_TARGET),--build-target $(BUILD_TARGET)) \
+		--snapshot \
 		--build-qemu $(SRC_PATH) -- \
 		$(if $(TARGET_LIST),--target-list=$(TARGET_LIST)) \
 		$(if $(EXTRA_CONFIGURE_OPTS),$(EXTRA_CONFIGURE_OPTS)), \

[v1,17/26] tests/vm: run test builds on snapshot

Commit Message

Patch