From patchwork Tue May 21 09:59:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jon Doron X-Patchwork-Id: 1102669 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="sxsyzgRx"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 457WmP23y8z9s6w for ; Tue, 21 May 2019 20:12:53 +1000 (AEST) Received: from localhost ([127.0.0.1]:50621 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hT1lL-0006H9-5Y for incoming@patchwork.ozlabs.org; Tue, 21 May 2019 06:12:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44960) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hT1ZR-0005yk-E7 for qemu-devel@nongnu.org; Tue, 21 May 2019 06:00:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hT1ZQ-0007uU-Bx for qemu-devel@nongnu.org; Tue, 21 May 2019 06:00:33 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:38612) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hT1ZQ-0007tG-5C for qemu-devel@nongnu.org; Tue, 21 May 2019 06:00:32 -0400 Received: by mail-wr1-x444.google.com with SMTP id d18so17870006wrs.5 for ; Tue, 21 May 2019 03:00:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LsYaQ4COmc6e9Lf4V+iWhN6mU2NGrUC/Gr04d6oOij8=; b=sxsyzgRx3abVJf9f3wedRCyqCgXjtMhSWBglozP+vnpB0/XGJbKBv3vDtCBt6sBZOo M0Azg50BHpHJH88FcFuLu9BhraikQ+PA32pH3mTqz4BGju2bwrdERQlApdNacG71fm1E Jc+f31S+vreTUYpa4bMxETmK75KUWbd/gN7/YtbIto+mm7Cx4R00+e7qMdY566zC1iTq DnWQFBREWyAYMfKolhqp0PA04+kkIUZ9dQvowFbwyiS2MJjGgmiHQpQMjBGYZt+wFYxJ 84p6tcCZdG7iqigCYiV9IPVOoKr4eNjtNpNS4MBeaXJalzvFwiJ+jMan0VKv9OuO2QHz glkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LsYaQ4COmc6e9Lf4V+iWhN6mU2NGrUC/Gr04d6oOij8=; b=C8LdGChyf9cBYOvit3hy+2mTywBze2cCiQl/lHG+sTkTqxDYdZGWwINgiszqs/UgpH +/z/mgy+L1onfI09OhC+i1A+0O7dk0kHaGcCTjs3/UtFw1D5LdO9pu0t8fWNfGLzmhnO bgQ+Tot8QPdHZnR9z8GtzGgFnUoL0tVE6JM2pBSJvX4gjpbFXnbkDghXuSZIcrSiJEBg yF71nx57y7PCI95E9gI2Re1RA523sy9ZH/g0toFfm4qdsj1pyzhMUGCeOwaMmIrM+dwf MnvB6IlKX6vZlhMfmAbGyN9+xLjU5Ov17tMvLyQnqK5xfLkCtBSpqmgZIf9cm1sbvsJj UcTw== X-Gm-Message-State: APjAAAXWhiTgWkzbdgovyhQOmeLC7m0xaO4wElW7F/yX2kfL1CnumwP2 sR/phUBVZFxloaMmEtl0cm+7fnuJ X-Google-Smtp-Source: APXvYqwxkPLDmMhEqfOW3fx5qkihjmgfvCfQPor/HN8aBz1tgQYWKCpZzHfwo4dWTtw23OwZfvKvwQ== X-Received: by 2002:a5d:640d:: with SMTP id z13mr25201789wru.299.1558432831097; Tue, 21 May 2019 03:00:31 -0700 (PDT) Received: from jondnuc.lan ([176.230.64.64]) by smtp.gmail.com with ESMTPSA id 65sm3080257wro.85.2019.05.21.03.00.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 21 May 2019 03:00:30 -0700 (PDT) From: Jon Doron To: qemu-devel@nongnu.org Date: Tue, 21 May 2019 12:59:47 +0300 Message-Id: <20190521095948.8204-20-arilou@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190521095948.8204-1-arilou@gmail.com> References: <20190521095948.8204-1-arilou@gmail.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 Subject: [Qemu-devel] [PATCH v10 19/20] gdbstub: Clear unused variables in gdb_handle_packet X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org, Jon Doron Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Jon Doron --- gdbstub.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 097b7d1231..9dd934a079 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2270,17 +2270,11 @@ static void handle_target_halt(GdbCmdContext *gdb_ctx, void *user_ctx) static int gdb_handle_packet(GDBState *s, const char *line_buf) { - const char *p; - int ch; - uint8_t mem_buf[MAX_PACKET_LENGTH]; - char buf[sizeof(mem_buf) + 1 /* trailing NUL */]; const GdbCmdParseEntry *cmd_parser = NULL; trace_gdbstub_io_command(line_buf); - p = line_buf; - ch = *p++; - switch(ch) { + switch (line_buf[0]) { case '!': put_packet(s, "OK"); break; @@ -2497,8 +2491,7 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) break; default: /* put empty packet */ - buf[0] = '\0'; - put_packet(s, buf); + put_packet(s, ""); break; }