| Message ID | 20190508061523.17666-3-peterx@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | kvm/migration: support KVM_CLEAR_DIRTY_LOG | expand |
On 08/05/19 01:15, Peter Xu wrote: > It's never used anywhere. > > Signed-off-by: Peter Xu <peterx@redhat.com> > --- > include/exec/memory.h | 17 ----------------- > memory.c | 8 -------- > 2 files changed, 25 deletions(-) > > diff --git a/include/exec/memory.h b/include/exec/memory.h > index 9144a47f57..e6140e8a04 100644 > --- a/include/exec/memory.h > +++ b/include/exec/memory.h > @@ -1254,23 +1254,6 @@ void memory_region_ram_resize(MemoryRegion *mr, ram_addr_t newsize, > */ > void memory_region_set_log(MemoryRegion *mr, bool log, unsigned client); > > -/** > - * memory_region_get_dirty: Check whether a range of bytes is dirty > - * for a specified client. > - * > - * Checks whether a range of bytes has been written to since the last > - * call to memory_region_reset_dirty() with the same @client. Dirty logging > - * must be enabled. > - * > - * @mr: the memory region being queried. > - * @addr: the address (relative to the start of the region) being queried. > - * @size: the size of the range being queried. > - * @client: the user of the logging information; %DIRTY_MEMORY_MIGRATION or > - * %DIRTY_MEMORY_VGA. > - */ > -bool memory_region_get_dirty(MemoryRegion *mr, hwaddr addr, > - hwaddr size, unsigned client); > - > /** > * memory_region_set_dirty: Mark a range of bytes as dirty in a memory region. > * > diff --git a/memory.c b/memory.c > index bb2b71ee38..0cce3a6fc5 100644 > --- a/memory.c > +++ b/memory.c > @@ -2027,14 +2027,6 @@ void memory_region_set_log(MemoryRegion *mr, bool log, unsigned client) > memory_region_transaction_commit(); > } > > -bool memory_region_get_dirty(MemoryRegion *mr, hwaddr addr, > - hwaddr size, unsigned client) > -{ > - assert(mr->ram_block); > - return cpu_physical_memory_get_dirty(memory_region_get_ram_addr(mr) + addr, > - size, client); > -} > - > void memory_region_set_dirty(MemoryRegion *mr, hwaddr addr, > hwaddr size) > { > Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
diff --git a/include/exec/memory.h b/include/exec/memory.h index 9144a47f57..e6140e8a04 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -1254,23 +1254,6 @@ void memory_region_ram_resize(MemoryRegion *mr, ram_addr_t newsize, */ void memory_region_set_log(MemoryRegion *mr, bool log, unsigned client); -/** - * memory_region_get_dirty: Check whether a range of bytes is dirty - * for a specified client. - * - * Checks whether a range of bytes has been written to since the last - * call to memory_region_reset_dirty() with the same @client. Dirty logging - * must be enabled. - * - * @mr: the memory region being queried. - * @addr: the address (relative to the start of the region) being queried. - * @size: the size of the range being queried. - * @client: the user of the logging information; %DIRTY_MEMORY_MIGRATION or - * %DIRTY_MEMORY_VGA. - */ -bool memory_region_get_dirty(MemoryRegion *mr, hwaddr addr, - hwaddr size, unsigned client); - /** * memory_region_set_dirty: Mark a range of bytes as dirty in a memory region. * diff --git a/memory.c b/memory.c index bb2b71ee38..0cce3a6fc5 100644 --- a/memory.c +++ b/memory.c @@ -2027,14 +2027,6 @@ void memory_region_set_log(MemoryRegion *mr, bool log, unsigned client) memory_region_transaction_commit(); } -bool memory_region_get_dirty(MemoryRegion *mr, hwaddr addr, - hwaddr size, unsigned client) -{ - assert(mr->ram_block); - return cpu_physical_memory_get_dirty(memory_region_get_ram_addr(mr) + addr, - size, client); -} - void memory_region_set_dirty(MemoryRegion *mr, hwaddr addr, hwaddr size) {
It's never used anywhere. Signed-off-by: Peter Xu <peterx@redhat.com> --- include/exec/memory.h | 17 ----------------- memory.c | 8 -------- 2 files changed, 25 deletions(-)