From patchwork Wed Apr 24 19:38:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jon Doron X-Patchwork-Id: 1090410 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="s6Wu3MfB"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44q9hF6NLZz9s4Y for ; Thu, 25 Apr 2019 05:42:37 +1000 (AEST) Received: from localhost ([127.0.0.1]:46330 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJNmt-0005tO-Qq for incoming@patchwork.ozlabs.org; Wed, 24 Apr 2019 15:42:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJNk3-0003k3-S0 for qemu-devel@nongnu.org; Wed, 24 Apr 2019 15:39:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJNjw-0003q6-6r for qemu-devel@nongnu.org; Wed, 24 Apr 2019 15:39:35 -0400 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:38789) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hJNjn-0003gR-4u for qemu-devel@nongnu.org; Wed, 24 Apr 2019 15:39:25 -0400 Received: by mail-wm1-x341.google.com with SMTP id w15so6717313wmc.3 for ; Wed, 24 Apr 2019 12:39:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=38LnIcypIDjektyoZrBn3/LYujk4iHNznA1yMdifAQQ=; b=s6Wu3MfBOmOKkulllTgcODgWpCK04ZsIUKFuDw1Izx/9j6sSt43e6MXcsALMRqIPjA bgiTOqgPnyISLgzGAogGKQbjaC0XumjOlbCY2z8aJkmfbA3vnJn36XyxBl+YIS8cugyJ 2wp3HvgsMyF0KfNXNN8fO1+YS3ZuV0YJNAAXtE8GwfnSf09WH0CB5D7EYkbo/x34Yfyq M4GuPag5J0omdAdVNJqs3KD0Y6zytLe4fPz8IlpCdl/lXKwzzrfp9EVvKf1O5NsArdmG d1cSsFpqXKBD/dsgWPE4kw4nVTKD2h/rWU2sdsr6d3lvw0w2ZkRsyIihyYhvjkwT7KrS NHag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=38LnIcypIDjektyoZrBn3/LYujk4iHNznA1yMdifAQQ=; b=QReegDOZFCqIEty+En79Iu3FAbt1Ze4/h2rufRm73YzDBYsorSAJgAOSOQQ2FNHUPf SbGh8pjsqlqTrRHtC/na+jPKE0BQdxEr3kFzapYy8PL/Mssm9FAEp0JrhGN/wX5MnQwo GFDtA6xq0cvxp7D4NN36kpKpuXgbY20oo8aYBUd5HbatO+o42cgci6DNb2A5OrTS5T1o JzXB3qo2UaeB5y4PqpHs5vguqrtVNK8z0LkM9O4/WwZrbJWYyqcNbqWbDJMF1N6OGdK/ Cd76b+/jBxG4HPSmb9QhGLc66NBrIj3fKAnStkE+A6VC+yaXp46VehiXRfy84faGgU0t Xyvw== X-Gm-Message-State: APjAAAXNw2iooI2vFfvmy7QPyyhFd2kzpKhEQ8JYeHp6TzEJA+QeDkpo vD6syGaDDxpoQCsZdikg+mhd2fKR X-Google-Smtp-Source: APXvYqxgNdieUOWWp2y7kTLdLETpxilLIvTt4vXwuGc9A7EYDilnJd08SrR6pQ5SDBIqkcjRZp3A+g== X-Received: by 2002:a7b:c848:: with SMTP id c8mr543428wml.110.1556134760771; Wed, 24 Apr 2019 12:39:20 -0700 (PDT) Received: from linux.local ([31.154.166.148]) by smtp.gmail.com with ESMTPSA id n18sm16281372wrt.16.2019.04.24.12.39.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Apr 2019 12:39:19 -0700 (PDT) From: Jon Doron To: qemu-devel@nongnu.org Date: Wed, 24 Apr 2019 22:38:41 +0300 Message-Id: <20190424193859.31817-3-arilou@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190424193859.31817-1-arilou@gmail.com> References: <20190424193859.31817-1-arilou@gmail.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 Subject: [Qemu-devel] [PATCH v5 03/21] gdbstub: Implement thread_alive (T pkt) with new infra X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jon Doron Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Jon Doron --- gdbstub.c | 43 ++++++++++++++++++++++++++++++++----------- 1 file changed, 32 insertions(+), 11 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index fdad1ac466..29ca6be3df 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1499,6 +1499,30 @@ static void handle_detach(GdbCmdContext *gdb_ctx, void *user_ctx) put_packet(s, "OK"); } +static void handle_thread_alive(GdbCmdContext *gdb_ctx, void *user_ctx) +{ + CPUState *cpu; + + if (!gdb_ctx->num_params) { + put_packet(gdb_ctx->s, "E22"); + return; + } + + if (gdb_ctx->params[0].thread_id.kind == GDB_READ_THREAD_ERR) { + put_packet(gdb_ctx->s, "E22"); + return; + } + + cpu = gdb_get_cpu(gdb_ctx->s, gdb_ctx->params[0].thread_id.pid, + gdb_ctx->params[0].thread_id.tid); + if (!cpu) { + put_packet(gdb_ctx->s, "E22"); + return; + } + + put_packet(gdb_ctx->s, "OK"); +} + static int gdb_handle_packet(GDBState *s, const char *line_buf) { CPUState *cpu; @@ -1799,17 +1823,14 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) } break; case 'T': - thread_kind = read_thread_id(p, &p, &pid, &tid); - if (thread_kind == GDB_READ_THREAD_ERR) { - put_packet(s, "E22"); - break; - } - cpu = gdb_get_cpu(s, pid, tid); - - if (cpu != NULL) { - put_packet(s, "OK"); - } else { - put_packet(s, "E22"); + { + static const GdbCmdParseEntry thread_alive_cmd_desc = { + .handler = handle_thread_alive, + .cmd = "T", + .cmd_startswith = 1, + .schema = "t0" + }; + cmd_parser = &thread_alive_cmd_desc; } break; case 'q':