diff mbox series

spapr: Remove NULL checks on error_propagate() calls

Message ID 20190318190148.18283-1-armbru@redhat.com
State New
Headers show
Series spapr: Remove NULL checks on error_propagate() calls | expand

Commit Message

Markus Armbruster March 18, 2019, 7:01 p.m. UTC
Patch created mechanically by rerunning:

  $  spatch --sp-file scripts/coccinelle/error_propagate_null.cocci \
	    --macro-file scripts/cocci-macro-file.h \
	    --dir . --in-place

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 hw/ppc/spapr_pci.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

David Gibson March 19, 2019, 4:25 a.m. UTC | #1
On Mon, Mar 18, 2019 at 08:01:48PM +0100, Markus Armbruster wrote:
> Patch created mechanically by rerunning:
> 
>   $  spatch --sp-file scripts/coccinelle/error_propagate_null.cocci \
> 	    --macro-file scripts/cocci-macro-file.h \
> 	    --dir . --in-place
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Applied to ppc-for-4.0, thanks.

> ---
>  hw/ppc/spapr_pci.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
> index 20915d2b3c..b63ed9d8da 100644
> --- a/hw/ppc/spapr_pci.c
> +++ b/hw/ppc/spapr_pci.c
> @@ -1488,9 +1488,7 @@ static void spapr_pci_plug(HotplugHandler *plug_handler,
>      }
>  
>  out:
> -    if (local_err) {
> -        error_propagate(errp, local_err);
> -    }
> +    error_propagate(errp, local_err);
>  }
>  
>  static void spapr_pci_unplug(HotplugHandler *plug_handler,
diff mbox series

Patch

diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
index 20915d2b3c..b63ed9d8da 100644
--- a/hw/ppc/spapr_pci.c
+++ b/hw/ppc/spapr_pci.c
@@ -1488,9 +1488,7 @@  static void spapr_pci_plug(HotplugHandler *plug_handler,
     }
 
 out:
-    if (local_err) {
-        error_propagate(errp, local_err);
-    }
+    error_propagate(errp, local_err);
 }
 
 static void spapr_pci_unplug(HotplugHandler *plug_handler,