From patchwork Sat Mar 16 22:39:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1057448 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44MHZr5lrHz9s3l for ; Sun, 17 Mar 2019 09:45:06 +1100 (AEDT) Received: from localhost ([127.0.0.1]:47429 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5I35-00008h-OK for incoming@patchwork.ozlabs.org; Sat, 16 Mar 2019 18:45:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5HyA-0004kY-5U for qemu-devel@nongnu.org; Sat, 16 Mar 2019 18:39:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5Hy8-0002LZ-U4 for qemu-devel@nongnu.org; Sat, 16 Mar 2019 18:39:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50390) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h5Hy8-0002L3-Hg; Sat, 16 Mar 2019 18:39:56 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7C1B5307D910; Sat, 16 Mar 2019 22:39:55 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-28.brq.redhat.com [10.40.204.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8F4281001DDE; Sat, 16 Mar 2019 22:39:43 +0000 (UTC) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Paolo Bonzini Date: Sat, 16 Mar 2019 23:39:16 +0100 Message-Id: <20190316223918.11917-4-philmd@redhat.com> In-Reply-To: <20190316223918.11917-1-philmd@redhat.com> References: <20190316223918.11917-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Sat, 16 Mar 2019 22:39:55 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 3/5] hw/isa/Kconfig: i82378 SuperIO requires PC speaker device X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , "Michael S. Tsirkin" , David Hildenbrand , Aleksandar Rikalo , Aleksandar Markovic , Helge Deller , Cornelia Huck , Mark Cave-Ayland , Eduardo Habkost , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, qemu-ppc@nongnu.org, Aurelien Jarno , David Gibson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" This fixes when configuring with --without-default-devices: $ qemu-system-ppc -M prep --nodefaults qemu-system-ppc: Machine type 'prep' is deprecated: use 40p machine type instead qemu-system-ppc: Unknown device 'isa-pcspk' for bus 'ISA' Aborted (core dumped) (gdb) bt #1 0x00007ffff5a11895 in __GI_abort () at abort.c:79 #2 0x0000555555845db3 in qdev_create (bus=0x55555641e360, name=name@entry=0x555555b1f338 "isa-pcspk") at hw/core/qdev.c:131 #3 0x000055555586b03e in isa_create (bus=bus@entry=0x55555641e360, name=name@entry=0x555555b1f338 "isa-pcspk") at hw/isa/isa-bus.c:162 #4 0x000055555586bf7b in pcspk_init (pit=0x5555561696b0, bus=0x55555641e360) at include/hw/audio/pcspk.h:38 #5 0x000055555586bf7b in i82378_realize (pci=, errp=0x7fffffffc960) at hw/isa/i82378.c:104 #6 0x000055555587e288 in pci_qdev_realize (qdev=0x55555641be60, errp=) at hw/pci/pci.c:2076 #7 0x0000555555846fb4 in device_set_realized (obj=, value=, errp=0x7fffffffcaf0) at hw/core/qdev.c:834 #8 0x00005555559273f7 in property_set_bool (obj=0x55555641be60, v=, name=, opaque=0x5555563df1c0, errp=0x7fffffffcaf0) at qom/object.c:2074 #9 0x000055555592ba1f in object_property_set_qobject (obj=obj@entry=0x55555641be60, value=value@entry=0x55555641d2b0, name=name@entry=0x555555b17175 "realized", errp=errp@entry=0x7fffffffcaf0) at qom/qom-qobject.c:27 #10 0x0000555555929355 in object_property_set_bool (obj=0x55555641be60, value=, name=0x555555b17175 "realized", errp=0x7fffffffcaf0) at qom/object.c:1332 #11 0x0000555555845f42 in qdev_init_nofail (dev=dev@entry=0x55555641be60) at hw/core/qdev.c:321 #12 0x000055555587ce06 in pci_create_simple_multifunction (name=name@entry=0x555555b1f346 "i82378", multifunction=false, devfn=devfn@entry=8, bus=bus@entry=0x55555628cfe8) at hw/pci/pci.c:2115 #13 0x000055555587ce06 in pci_create_simple (bus=bus@entry=0x55555628cfe8, devfn=devfn@entry=8, name=name@entry=0x555555b1f346 "i82378") at hw/pci/pci.c:2126 #14 0x000055555575e62c in ppc_prep_init (machine=0x55555609af00) at hw/ppc/prep.c:516 #15 0x000055555584d57b in machine_run_board_init (machine=0x55555609af00) at hw/core/machine.c:1030 Fixes: dd0ff8191ab Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- hw/isa/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig index 1bb5ccdba7..b40075df89 100644 --- a/hw/isa/Kconfig +++ b/hw/isa/Kconfig @@ -11,6 +11,7 @@ config I82378 select I8254 select I82374 select MC146818RTC + select PCSPK config PC87312 bool