From patchwork Tue Mar 12 16:19:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 1055531 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="ZHsnqOCU"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44JgVG2JrTz9s70 for ; Wed, 13 Mar 2019 03:32:06 +1100 (AEDT) Received: from localhost ([127.0.0.1]:55421 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3kJw-0007Wo-5J for incoming@patchwork.ozlabs.org; Tue, 12 Mar 2019 12:32:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3k7o-000689-Q1 for qemu-devel@nongnu.org; Tue, 12 Mar 2019 12:19:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h3k7h-0003zM-Pu for qemu-devel@nongnu.org; Tue, 12 Mar 2019 12:19:29 -0400 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]:40047) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h3k7c-0003uY-LP for qemu-devel@nongnu.org; Tue, 12 Mar 2019 12:19:22 -0400 Received: by mail-pg1-x52d.google.com with SMTP id u9so2188033pgo.7 for ; Tue, 12 Mar 2019 09:19:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=qKUZoF/a2Kkdnv24SRPFQ5wuvupHDLeUIyF9pRIxhQc=; b=ZHsnqOCU5MwAcNbBCt5T/I1p7yvtyJM3YELgKGhYC9H6omqpobmsCFgKGzeIfilc5r Gg93k/4o/YNFPEkQprfPnUlvEpkSVxkqlgVrYVC67zXV6y9VK1glmxpsQksZhgs/j+L1 hc7a33Nsi33pW2vZRxs6hsP8bDSixP/6f9D4gjeFyEydKMuZYEmC1MeVbDBfk7k7PW7d /mnReKbmSUdNwSbjWna7txl+eD+UAnP56vJtJJA/o+5Qak6VdzGxQk7rNOQPNACxcmkK rEDgNXNfqYPizXbiqTNtI0+myrXbOyNc+cImNoK5uRC0A97on962fUNzhPqj5bFJasOX XRog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=qKUZoF/a2Kkdnv24SRPFQ5wuvupHDLeUIyF9pRIxhQc=; b=JMvBXG2CF3AINSByTVWrJw1hbvP44KAbSGu87PqUerYnM+P5poWSDK8aKLNLKLSmYO aO/Xh1P8tEVhaeBA5463sJQKURIzKn+XfygBl3ivoWEK1Rlgegyec5dherG6o8vZwS+r XBIO6aOQ5F8DAGGAmQ4fHXEDw3ojpxsO5Z52F6tx8+nQ07cVqj0UmQpHbQGB96eNis80 ZepaQHjmZ3F/+K7w/zsYhzVVhWVDf95Gfuhz5RH60VZpLpZuG94GGjfoam7phvwtjPF3 1fyKXHM74Vosm6cJN2iheBzVMvWDIIN3ehnVB7SjxU46oY2Zy6YQpiseEFysFMAendo5 Slvw== X-Gm-Message-State: APjAAAWbG0bpJYLGyTxw2Y/MBIR4NbEkfh3rksbAHe8u8Tf6a4HalAIQ UuhGsj0Ah2pezJCp3Kp1Ap4sDwTvhSs= X-Google-Smtp-Source: APXvYqzI5MEwFK9Rz+PhsWtAFuBSK8gQgKTjxbVnPW0cmDCyZAvs7zIhIS/cvIPa3xFqnE6TMziCEA== X-Received: by 2002:a63:7341:: with SMTP id d1mr36532084pgn.405.1552407557155; Tue, 12 Mar 2019 09:19:17 -0700 (PDT) Received: from cloudburst.twiddle.net (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id q62sm12605644pga.32.2019.03.12.09.19.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Mar 2019 09:19:16 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 12 Mar 2019 09:19:00 -0700 Message-Id: <20190312161904.31130-8-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190312161904.31130-1-richard.henderson@linaro.org> References: <20190312161904.31130-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::52d Subject: [Qemu-devel] [PULL 07/11] target/hppa: ignore DIAG opcode X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Sven Schnelle Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Sven Schnelle DIAG is usually only used by diagnostics software as it's CPU specific. In most of the cases it's better to ignore it and log a message that it's not implemented. Signed-off-by: Sven Schnelle Message-Id: <20190311191602.25796-7-svens@stackframe.org> [rth: Free the nullify condition.] Signed-off-by: Richard Henderson --- target/hppa/translate.c | 7 +++++++ target/hppa/insns.decode | 3 +++ 2 files changed, 10 insertions(+) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index c4815d7e1a..f3e78b8e22 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -4048,6 +4048,13 @@ static bool trans_fmpyfadd_d(DisasContext *ctx, arg_fmpyfadd_d *a) return nullify_end(ctx); } +static bool trans_diag(DisasContext *ctx, arg_diag *a) +{ + qemu_log_mask(LOG_UNIMP, "DIAG opcode ignored\n"); + cond_free(&ctx->null_cond); + return true; +} + static void hppa_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cs) { DisasContext *ctx = container_of(dcbase, DisasContext, base); diff --git a/target/hppa/insns.decode b/target/hppa/insns.decode index 55ff39dd05..098370c2f0 100644 --- a/target/hppa/insns.decode +++ b/target/hppa/insns.decode @@ -525,3 +525,6 @@ fmpy_d 001110 ..... ..... 010 ..... ... ..... @f0e_d_3 fdiv_d 001110 ..... ..... 011 ..... ... ..... @f0e_d_3 xmpyu 001110 ..... ..... 010 .0111 .00 t:5 r1=%ra64 r2=%rb64 + +# diag +diag 000101 ----- ----- ---- ---- ---- ----