| Message ID | 20190311165017.32247-2-kwolf@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | file-posix: Make auto-read-only dynamic | expand |
On 3/11/19 11:50 AM, Kevin Wolf wrote: > tests/virtio-blk-test uses a temporary image file that it deletes while > QEMU is still running, so it can't be reopened when writers are > attached or detached. Disable auto-read-only to keep it always writable. > > Signed-off-by: Kevin Wolf <kwolf@redhat.com> > --- > tests/virtio-blk-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Looks like I started reviewing v1 even though I see v2 has been posted. R-b carries forward: Reviewed-by: Eric Blake <eblake@redhat.com> > > diff --git a/tests/virtio-blk-test.c b/tests/virtio-blk-test.c > index b02be0274e..b65365934b 100644 > --- a/tests/virtio-blk-test.c > +++ b/tests/virtio-blk-test.c > @@ -751,7 +751,7 @@ static void *virtio_blk_test_setup(GString *cmd_line, void *arg) > char *tmp_path = drive_create(); > > g_string_append_printf(cmd_line, > - " -drive if=none,id=drive0,file=%s,format=raw " > + " -drive if=none,id=drive0,file=%s,format=raw,auto-read-only=off " > "-drive if=none,id=drive1,file=null-co://,format=raw ", > tmp_path); > >
diff --git a/tests/virtio-blk-test.c b/tests/virtio-blk-test.c index b02be0274e..b65365934b 100644 --- a/tests/virtio-blk-test.c +++ b/tests/virtio-blk-test.c @@ -751,7 +751,7 @@ static void *virtio_blk_test_setup(GString *cmd_line, void *arg) char *tmp_path = drive_create(); g_string_append_printf(cmd_line, - " -drive if=none,id=drive0,file=%s,format=raw " + " -drive if=none,id=drive0,file=%s,format=raw,auto-read-only=off " "-drive if=none,id=drive1,file=null-co://,format=raw ", tmp_path);
tests/virtio-blk-test uses a temporary image file that it deletes while QEMU is still running, so it can't be reopened when writers are attached or detached. Disable auto-read-only to keep it always writable. Signed-off-by: Kevin Wolf <kwolf@redhat.com> --- tests/virtio-blk-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)