From patchwork Sun Mar 10 00:34:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1053895 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ZtMkXkH9"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44H2QS2cYjz9s9h for ; Sun, 10 Mar 2019 11:38:08 +1100 (AEDT) Received: from localhost ([127.0.0.1]:38108 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2mTe-0005Ya-B0 for incoming@patchwork.ozlabs.org; Sat, 09 Mar 2019 19:38:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2mQI-0003Nu-V5 for qemu-devel@nongnu.org; Sat, 09 Mar 2019 19:34:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h2mQI-0001GK-4U for qemu-devel@nongnu.org; Sat, 09 Mar 2019 19:34:38 -0500 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:34621) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h2mQH-0001FD-UI for qemu-devel@nongnu.org; Sat, 09 Mar 2019 19:34:38 -0500 Received: by mail-wr1-x442.google.com with SMTP id f14so1284413wrg.1 for ; Sat, 09 Mar 2019 16:34:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lGz9YZRWGrXDP3+rBti57r/rIWAYSgdccohb1TG0B8I=; b=ZtMkXkH9KD7P/9dluRYhSFaoBMBY1jpuXbtmZcfjq9m4Xwo0ov/ePMGmEwNZ8sv8oQ 8q0FDiuLF7SvLawqs3cMErRn3wOomHaAts45W9tyWBWO2oK5GPeWNADTouwnJutrymTi ehUB9RNzs3X5cJFcu0r/McXsSOW8qQfudo1eP5/pncs5tOX2NoDtaJ4/Ev9KL8Nmtk4Q uIj9qAe1mV8O9ksHFN3na7SyulmmQ9bELYlqW53f/dutOHRVXUH+bORm43U/AQML9Fov PETGQZHdLnOy1As6p3/pRyQqnAN1GEB8pxqwQUV9t3mcf3aQ+yZ8XL+MA7Ng/Sm5z7tz UQzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=lGz9YZRWGrXDP3+rBti57r/rIWAYSgdccohb1TG0B8I=; b=ry5zBzZaSOkXGXBnGQiDZ0172TYmdwVl78pws6TfPQORyWGqqJz9pIKfziUR16xHDP /dvqQZDUeIXvfQt8BxGlIzRqjfweVHtx5zCiCVsrQ3cG9sCuA/wnGYJZQjaYaEHpqi6k RfKYfB/nD3+KPulJEH8gZ9ZRV3f9xE9iXopic3/ii1HOe8DkLnZXfbDWaTMcmnNTDhfv ViPxZt/llbz56Ttt8CkARwh4qf+E6Mw/e0bnnZCGqYrIHBkNBkIvxC7A1sr2z6VGwAhq 9u8lL2jbsX6pD78OoClnlWIPCOE9G9Tk6ixdPHWQPvxsQg3HkGk5jlZhzA5uvx+1UsXK xiJw== X-Gm-Message-State: APjAAAWTTwQjjkRxEwfHerXZ2/FysIkrdUWBrRmGx62A30vQTjGGzlDP V7Mn/cCDTvsBGhIIWyLYvsQ= X-Google-Smtp-Source: APXvYqzpSyJpLRaVAgZUm55R+RzbfwVdxBDRgnTZaTiqrvGzjjdXcmzad2F2Vwi7GG4svIs2vUqHzw== X-Received: by 2002:adf:cd04:: with SMTP id w4mr15719868wrm.25.1552178076929; Sat, 09 Mar 2019 16:34:36 -0800 (PST) Received: from x1.local (43.red-88-25-181.staticip.rima-tde.net. [88.25.181.43]) by smtp.gmail.com with ESMTPSA id 12sm29164462wme.25.2019.03.09.16.34.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 09 Mar 2019 16:34:36 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: Laurent Vivier , Richard Henderson Date: Sun, 10 Mar 2019 01:34:27 +0100 Message-Id: <20190310003428.11723-6-f4bug@amsat.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190310003428.11723-1-f4bug@amsat.org> References: <20190310003428.11723-1-f4bug@amsat.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::442 Subject: [Qemu-devel] [PATCH 5/6] target/m68k: Optimize rotate_x() using extract_i32() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Optimize rotate_x() using tcg_gen_extract_i32(). We can now free the 'sz' tcg_temp earlier. Since it is allocated with tcg_const_i32(), free it with tcg_temp_free_i32(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/m68k/translate.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index f43ac07b7f..b51b8a2a12 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -3686,6 +3686,7 @@ static TCGv rotate_x(TCGv reg, TCGv shift, int left, int size) tcg_gen_sub_i32(shl, shl, shift); /* shl = size + 1 - shift */ tcg_gen_sub_i32(shx, sz, shift); /* shx = size - shift */ } + tcg_temp_free_i32(sz); /* reg = (reg << shl) | (reg >> shr) | (x << shx); */ @@ -3701,9 +3702,7 @@ static TCGv rotate_x(TCGv reg, TCGv shift, int left, int size) /* X = (reg >> size) & 1 */ X = tcg_temp_new(); - tcg_gen_shr_i32(X, reg, sz); - tcg_gen_andi_i32(X, X, 1); - tcg_temp_free(sz); + tcg_gen_extract_i32(X, reg, size, 1); return X; }