diff mbox series

isa: Add APM and ACPI dependencies for VT82C686

Message ID 20190309165740.0755B7480BD@zero.eik.bme.hu
State New
Headers show
Series isa: Add APM and ACPI dependencies for VT82C686 | expand

Commit Message

BALATON Zoltan March 9, 2019, 4:48 p.m. UTC
Compiling vt82c686.c fails without APM and ACPI_PM funtions. Add
dependency on these in Kconfig to fix this.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
 hw/isa/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

Comments

Paolo Bonzini March 11, 2019, 1:34 p.m. UTC | #1
On 09/03/19 17:48, BALATON Zoltan wrote:
> Compiling vt82c686.c fails without APM and ACPI_PM funtions. Add
> dependency on these in Kconfig to fix this.
> 
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
>  hw/isa/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
> index 57e09a0cb8..e092da3fc3 100644
> --- a/hw/isa/Kconfig
> +++ b/hw/isa/Kconfig
> @@ -36,6 +36,8 @@ config VT82C686
>      select ACPI_SMBUS
>      select SERIAL_ISA
>      select FDC
> +    select APM
> +    select ACPI_X86
>  
>  config SMC37C669
>      bool
> 

Queued, thanks.

Paolo
Philippe Mathieu-Daudé March 11, 2019, 2:54 p.m. UTC | #2
On 3/9/19 5:48 PM, BALATON Zoltan wrote:
> Compiling vt82c686.c fails without APM and ACPI_PM funtions. Add
> dependency on these in Kconfig to fix this.
> 
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
>  hw/isa/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
> index 57e09a0cb8..e092da3fc3 100644
> --- a/hw/isa/Kconfig
> +++ b/hw/isa/Kconfig
> @@ -36,6 +36,8 @@ config VT82C686
>      select ACPI_SMBUS
>      select SERIAL_ISA
>      select FDC
> +    select APM

Correct, I missed this one.

> +    select ACPI_X86

NACK it does require ACPI but not X86.

ACPI_X86 is messy. I tried to fix VT82C686 in my "Kconfig MIPS" series,
but I might have to include this in my 'Kconfig PIIX' series.

>  
>  config SMC37C669
>      bool
>
Paolo Bonzini March 11, 2019, 4:33 p.m. UTC | #3
On 11/03/19 15:54, Philippe Mathieu-Daudé wrote:
> On 3/9/19 5:48 PM, BALATON Zoltan wrote:
>> Compiling vt82c686.c fails without APM and ACPI_PM funtions. Add
>> dependency on these in Kconfig to fix this.
>>
>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>> ---
>>  hw/isa/Kconfig | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
>> index 57e09a0cb8..e092da3fc3 100644
>> --- a/hw/isa/Kconfig
>> +++ b/hw/isa/Kconfig
>> @@ -36,6 +36,8 @@ config VT82C686
>>      select ACPI_SMBUS
>>      select SERIAL_ISA
>>      select FDC
>> +    select APM
> 
> Correct, I missed this one.
> 
>> +    select ACPI_X86
> 
> NACK it does require ACPI but not X86.
> 
> ACPI_X86 is messy. I tried to fix VT82C686 in my "Kconfig MIPS" series,
> but I might have to include this in my 'Kconfig PIIX' series.
> 
>>  
>>  config SMC37C669
>>      bool
>>

Oh, I thought this was a build fix.  But since MIPS does select these,
I've unqueued this patch and I'll let the maintainers pick Philippe's
series.

Paolo
diff mbox series

Patch

diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
index 57e09a0cb8..e092da3fc3 100644
--- a/hw/isa/Kconfig
+++ b/hw/isa/Kconfig
@@ -36,6 +36,8 @@  config VT82C686
     select ACPI_SMBUS
     select SERIAL_ISA
     select FDC
+    select APM
+    select ACPI_X86
 
 config SMC37C669
     bool