| Message ID | 20190307223548.20516-4-clg@kaod.org |
|---|---|
| State | New |
| Headers | show |
| Series | ppc: add POWER9 support to the PowerNV platform | expand |
On Thu, Mar 07, 2019 at 11:35:36PM +0100, Cédric Le Goater wrote: > The PowerNV LPC Controller exposes different sets of registers for > each of the functional units it encompasses, among which the OPB > (On-Chip Peripheral Bus) Master and Arbitrer and the LPC HOST > Controller. > > The mapping addresses of each register range are correct but the sizes > are too large. Fix the sizes and define the OPB Arbitrer range to fill > the gap between the OPB Master registers and the LPC HOST Controller > registers. > > Signed-off-by: Cédric Le Goater <clg@kaod.org> Applied, thanks. > --- > > Changes in v2 : > > - wrote a commit log > > hw/ppc/pnv_lpc.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/hw/ppc/pnv_lpc.c b/hw/ppc/pnv_lpc.c > index 9b18ce55e391..547be609cafe 100644 > --- a/hw/ppc/pnv_lpc.c > +++ b/hw/ppc/pnv_lpc.c > @@ -89,10 +89,11 @@ enum { > #define LPC_FW_OPB_SIZE 0x10000000 > > #define LPC_OPB_REGS_OPB_ADDR 0xc0010000 > -#define LPC_OPB_REGS_OPB_SIZE 0x00002000 > +#define LPC_OPB_REGS_OPB_SIZE 0x00000060 > +#define LPC_OPB_REGS_OPBA_ADDR 0xc0011000 > +#define LPC_OPB_REGS_OPBA_SIZE 0x00000008 > #define LPC_HC_REGS_OPB_ADDR 0xc0012000 > -#define LPC_HC_REGS_OPB_SIZE 0x00001000 > - > +#define LPC_HC_REGS_OPB_SIZE 0x00000100 > > static int pnv_lpc_dt_xscom(PnvXScomInterface *dev, void *fdt, int xscom_offset) > {
diff --git a/hw/ppc/pnv_lpc.c b/hw/ppc/pnv_lpc.c index 9b18ce55e391..547be609cafe 100644 --- a/hw/ppc/pnv_lpc.c +++ b/hw/ppc/pnv_lpc.c @@ -89,10 +89,11 @@ enum { #define LPC_FW_OPB_SIZE 0x10000000 #define LPC_OPB_REGS_OPB_ADDR 0xc0010000 -#define LPC_OPB_REGS_OPB_SIZE 0x00002000 +#define LPC_OPB_REGS_OPB_SIZE 0x00000060 +#define LPC_OPB_REGS_OPBA_ADDR 0xc0011000 +#define LPC_OPB_REGS_OPBA_SIZE 0x00000008 #define LPC_HC_REGS_OPB_ADDR 0xc0012000 -#define LPC_HC_REGS_OPB_SIZE 0x00001000 - +#define LPC_HC_REGS_OPB_SIZE 0x00000100 static int pnv_lpc_dt_xscom(PnvXScomInterface *dev, void *fdt, int xscom_offset) {
The PowerNV LPC Controller exposes different sets of registers for each of the functional units it encompasses, among which the OPB (On-Chip Peripheral Bus) Master and Arbitrer and the LPC HOST Controller. The mapping addresses of each register range are correct but the sizes are too large. Fix the sizes and define the OPB Arbitrer range to fill the gap between the OPB Master registers and the LPC HOST Controller registers. Signed-off-by: Cédric Le Goater <clg@kaod.org> --- Changes in v2 : - wrote a commit log hw/ppc/pnv_lpc.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)