| Message ID | 20190228165508.21594-6-chen.zhang@intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | Migration/colo: Fix upstream bugs when occur failover | expand |
On 2/28/19 10:55 AM, Zhang Chen wrote: > From: Zhang Chen <chen.zhang@intel.com> > > Remove the "active" variable in example for query-colo-status. > > Signed-off-by: Zhang Chen <chen.zhang@intel.com> > --- > qapi/migration.json | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake <eblake@redhat.com> Might be nice to mention that the doc bug has been present since the command's introduction in commit f56c0065. > > diff --git a/qapi/migration.json b/qapi/migration.json > index 48e21880a3..f4c1762dfc 100644 > --- a/qapi/migration.json > +++ b/qapi/migration.json > @@ -1342,7 +1342,7 @@ > # Example: > # > # -> { "execute": "query-colo-status" } > -# <- { "return": { "mode": "primary", "active": true, "reason": "request" } } > +# <- { "return": { "mode": "primary", "reason": "request" } } > # > # Since: 3.1 > ## >
-----Original Message----- From: Eric Blake [mailto:eblake@redhat.com] Sent: Friday, March 1, 2019 1:07 AM To: Zhang, Chen <chen.zhang@intel.com>; Li Zhijian <lizhijian@cn.fujitsu.com>; Zhang Chen <zhangckid@gmail.com>; Dr. David Alan Gilbert <dgilbert@redhat.com>; Juan Quintela <quintela@redhat.com>; zhanghailiang <zhang.zhanghailiang@huawei.com>; Markus Armbruster <armbru@redhat.com>; qemu-dev <qemu-devel@nongnu.org> Subject: Re: [PATCH V2 5/7] qapi/migration.json: Remove a variable that doesn't exist in example On 2/28/19 10:55 AM, Zhang Chen wrote: > From: Zhang Chen <chen.zhang@intel.com> > > Remove the "active" variable in example for query-colo-status. > > Signed-off-by: Zhang Chen <chen.zhang@intel.com> > --- > qapi/migration.json | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake <eblake@redhat.com> Might be nice to mention that the doc bug has been present since the command's introduction in commit f56c0065. Sure, will write in next version. Thanks Zhang Chen > > diff --git a/qapi/migration.json b/qapi/migration.json index > 48e21880a3..f4c1762dfc 100644 > --- a/qapi/migration.json > +++ b/qapi/migration.json > @@ -1342,7 +1342,7 @@ > # Example: > # > # -> { "execute": "query-colo-status" } -# <- { "return": { "mode": > "primary", "active": true, "reason": "request" } } > +# <- { "return": { "mode": "primary", "reason": "request" } } > # > # Since: 3.1 > ## > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
diff --git a/qapi/migration.json b/qapi/migration.json index 48e21880a3..f4c1762dfc 100644 --- a/qapi/migration.json +++ b/qapi/migration.json @@ -1342,7 +1342,7 @@ # Example: # # -> { "execute": "query-colo-status" } -# <- { "return": { "mode": "primary", "active": true, "reason": "request" } } +# <- { "return": { "mode": "primary", "reason": "request" } } # # Since: 3.1 ##