From patchwork Thu Feb 21 18:57:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 1046391 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="A4F6Z8Xp"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4453sv09B4z9sMM for ; Fri, 22 Feb 2019 06:08:49 +1100 (AEDT) Received: from localhost ([127.0.0.1]:37008 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwti9-0000u2-Ev for incoming@patchwork.ozlabs.org; Thu, 21 Feb 2019 14:08:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwtXo-0008S3-Ux for qemu-devel@nongnu.org; Thu, 21 Feb 2019 13:58:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwtXn-0007Qw-1g for qemu-devel@nongnu.org; Thu, 21 Feb 2019 13:58:04 -0500 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:34632) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gwtXl-0007OW-4e for qemu-devel@nongnu.org; Thu, 21 Feb 2019 13:58:02 -0500 Received: by mail-wr1-x42f.google.com with SMTP id f14so31906694wrg.1 for ; Thu, 21 Feb 2019 10:57:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=aDzg/q6Ou+Q3G8inj+NI1UIvQeU4RYZ3ZNczYWKT/14=; b=A4F6Z8XpjcsKr2vzelLDHuasDVsVuVh1hnsKSR/hCcyCHPpPQgn3H5Yy3R+XcAnAV7 pyGAv0zFcPyTJ9iz1jn7lKgN4NQDYXJd19nll8L8Tk02g7rXyEO3AzXcIoRjpGeTg2lQ duD5Q34EtsHSzQIhUNABkYiSS9Qp/NPmBbrKPMLw9HgQyLcAXwCfbtoL+yLJcerAINFc RyOI4LCRrC4Rc9SNIVMzCMMvXQVsGdklHWq7RljFWc+jTlG3rk44eTkHDxkHD6S7hz/+ 4jq66BYnGPmGIF9tKqlCFJpnhMMile/1H001JjwppA+t0X4KK7z9XQ3WI0H3d5A1ICZ3 HLNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aDzg/q6Ou+Q3G8inj+NI1UIvQeU4RYZ3ZNczYWKT/14=; b=hRNCYutxZJW9uus1Ycku9kCtpRd5Z1tp5sVhCUDYmkK3FF0aDThOFBX/WCFT0/O1+l anmXqD/HtUaExnm/hoOR7jXWahOi3JMRU0Y5X92Siluj3XiGU0TXuNlxB4YO6wm6VaTd G8d1wbasAgdLY2odzAg2t6YcDiqV8Gn1S5UkBUKnfatjyTKaDsb3hY43eOXBsfwcdheY sPRkDDsBFM3a78K2A8doShZNA9PaV2jAUUwkng7Fts9UsG02GAGMExiNva3ypTfvbmZW VNistDzgOPYRIRO/ZFCDWKHT5zz/uba3HG16DSXJi/Sk3I1snrWTKce43v13D4D9PZM3 jdbg== X-Gm-Message-State: AHQUAuaU+a246dluV8ltQKmWcT13WRuZ7a8N+XMdaN3fV49Wgez7AHkT 2wHVfaXCcxoDQlUH5MEjNkiQOAF4/vs= X-Google-Smtp-Source: AHgI3IbzVWycGhQsWV0UgSnxWPowaPaUGY6YAUNn32TzMIqpvRpbNfpRXqX3H0UsVQGKIJGLQvQbtg== X-Received: by 2002:adf:d0c9:: with SMTP id z9mr17867wrh.132.1550775478778; Thu, 21 Feb 2019 10:57:58 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id c18sm29065085wre.32.2019.02.21.10.57.57 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Feb 2019 10:57:58 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Date: Thu, 21 Feb 2019 18:57:31 +0000 Message-Id: <20190221185739.25362-14-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190221185739.25362-1-peter.maydell@linaro.org> References: <20190221185739.25362-1-peter.maydell@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42f Subject: [Qemu-devel] [PULL 13/21] hw/char/pl011: Use '0x' prefix when logging hex numbers X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" The pl011 logs when the guest makes a bad access. It prints the address offset in hex but confusingly omits the '0x' prefix; add it. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- hw/char/pl011.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/char/pl011.c b/hw/char/pl011.c index 29f4e5eb224..e5dd448f854 100644 --- a/hw/char/pl011.c +++ b/hw/char/pl011.c @@ -143,7 +143,7 @@ static uint64_t pl011_read(void *opaque, hwaddr offset, break; default: qemu_log_mask(LOG_GUEST_ERROR, - "pl011_read: Bad offset %x\n", (int)offset); + "pl011_read: Bad offset 0x%x\n", (int)offset); r = 0; break; } @@ -232,7 +232,7 @@ static void pl011_write(void *opaque, hwaddr offset, break; default: qemu_log_mask(LOG_GUEST_ERROR, - "pl011_write: Bad offset %x\n", (int)offset); + "pl011_write: Bad offset 0x%x\n", (int)offset); } }