| Message ID | 20190207180012.27303-3-crosa@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add "boot_linux" acceptance test | expand |
FWIW, Cc'ing qemu-img maintainers. On 2/7/19 7:00 PM, Cleber Rosa wrote: > Tests using the avocado.utils.vmimage library make use of qemu-img, > and because it makes sense to use the version matching the rest of the > source code, let's make sure it gets built. > > Its selection, instead of a possible qemu-img binary installed system > wide, is already dealt with by the change that adds the build dir to > the PATH during the test execution. > > This is based on the same work for qemu-iotests, and suggested by its > author: > > - https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg00951.html > > CC: Philippe Mathieu-Daudé <philmd@redhat.com> > Signed-off-by: Cleber Rosa <crosa@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > tests/Makefile.include | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index b39e989f72..9a2fb94f4a 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -1111,7 +1111,7 @@ $(TESTS_RESULTS_DIR): > > check-venv: $(TESTS_VENV_DIR) > > -check-acceptance: check-venv $(TESTS_RESULTS_DIR) > +check-acceptance: check-venv $(TESTS_RESULTS_DIR) qemu-img$(EXESUF) > $(call quiet-command, \ > $(TESTS_VENV_DIR)/bin/python -m avocado \ > --show=$(AVOCADO_SHOW) run --job-results-dir=$(TESTS_RESULTS_DIR) \ >
diff --git a/tests/Makefile.include b/tests/Makefile.include index b39e989f72..9a2fb94f4a 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -1111,7 +1111,7 @@ $(TESTS_RESULTS_DIR): check-venv: $(TESTS_VENV_DIR) -check-acceptance: check-venv $(TESTS_RESULTS_DIR) +check-acceptance: check-venv $(TESTS_RESULTS_DIR) qemu-img$(EXESUF) $(call quiet-command, \ $(TESTS_VENV_DIR)/bin/python -m avocado \ --show=$(AVOCADO_SHOW) run --job-results-dir=$(TESTS_RESULTS_DIR) \
Tests using the avocado.utils.vmimage library make use of qemu-img, and because it makes sense to use the version matching the rest of the source code, let's make sure it gets built. Its selection, instead of a possible qemu-img binary installed system wide, is already dealt with by the change that adds the build dir to the PATH during the test execution. This is based on the same work for qemu-iotests, and suggested by its author: - https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg00951.html CC: Philippe Mathieu-Daudé <philmd@redhat.com> Signed-off-by: Cleber Rosa <crosa@redhat.com> --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)