From patchwork Fri Feb 1 16:06:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 1034919 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="Rsd8dc4R"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43rjJB38lJz9sMl for ; Sat, 2 Feb 2019 03:30:18 +1100 (AEDT) Received: from localhost ([127.0.0.1]:57550 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpbho-0001gf-97 for incoming@patchwork.ozlabs.org; Fri, 01 Feb 2019 11:30:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpbMF-0008Id-MC for qemu-devel@nongnu.org; Fri, 01 Feb 2019 11:08:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gpbMB-0003kq-K2 for qemu-devel@nongnu.org; Fri, 01 Feb 2019 11:07:59 -0500 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]:55109) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gpbMB-0003fn-8b for qemu-devel@nongnu.org; Fri, 01 Feb 2019 11:07:55 -0500 Received: by mail-wm1-x334.google.com with SMTP id a62so6651364wmh.4 for ; Fri, 01 Feb 2019 08:07:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=ymo0qN3eVsrzEBkdLNPy4tKfT4b2G+wrfkd/axkYG+w=; b=Rsd8dc4RTcXnWcMnnhLqkzFCA9UD6MZtMV0UOm9gHiVldr6rQwvBlbFqShHvA0UVEh MDyImqXxGFbCe9hysBHqL8vIEiCnMtqLLYfRYdORYC3Zw1U30gbL/r/Z+kM2g1xu+S/U +PgPTw9baZfUxuQ2D+cezuy055L0DM2UkLCaU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ymo0qN3eVsrzEBkdLNPy4tKfT4b2G+wrfkd/axkYG+w=; b=JQCKhPFQpS0w7H2bpaCa0IYxHo7aqM6a6HgvCwqOCZIt6IxNbst7cn30u+KP7iVu8d QKTKqI9YTrqXVf+PYJsGfvNj8QTBQGDHPgAUQVM/u0t6gifDJjiOchtyPczqp/rmvyPw mo/XxUkUYFgJbfxIF8C2NTnm7DM73GnKAwp9I9cktd3XaxCXGHBHrY9V9Piq+HyE4ry+ ytJTd9xZxt3VcNFK0C1JUQeMC2IXRBOGiLTcipiY6UhfK4R2ia6NWgYA7V4sLWIdCgot dnK55uBLJuaY8n28lnUwqiCcCAaTWOkMjRzHslL2XSDo6AskM/2jb9wbcOCcpFciznV1 MHXw== X-Gm-Message-State: AHQUAub89TZZkNol9rTpkFnXpSpNFCm/w7Bto4q0XUFsTcdYGxoVwqhs ZE6T2qAgAhz8Y3xAMQCqglvmLYUA48uRkQ== X-Google-Smtp-Source: AHgI3IbPvgEmTIr8bsme+uGFG3DPsKQewS6ZJbQrRjf9nyanMpdgVSUCNhvCdyVC5Y02WatlhAk4Nw== X-Received: by 2002:a1c:e242:: with SMTP id z63mr2989505wmg.2.1549037271177; Fri, 01 Feb 2019 08:07:51 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id n6sm2847250wmk.9.2019.02.01.08.07.50 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Feb 2019 08:07:50 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Date: Fri, 1 Feb 2019 16:06:50 +0000 Message-Id: <20190201160653.13829-45-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190201160653.13829-1-peter.maydell@linaro.org> References: <20190201160653.13829-1-peter.maydell@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::334 Subject: [Qemu-devel] [PULL 44/47] target/arm: fix decoding of B{, L}RA{A, B} X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Remi Denis-Courmont A flawed test lead to the instructions always being treated as unallocated encodings. Fixes: https://bugs.launchpad.net/bugs/1813460 Signed-off-by: Remi Denis-Courmont Reviewed-by: Richard Henderson Signed-off-by: Peter Maydell --- target/arm/translate-a64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index b864ac7a69f..a1997e3ae28 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -2036,7 +2036,7 @@ static void disas_uncond_b_reg(DisasContext *s, uint32_t insn) if (!dc_isar_feature(aa64_pauth, s)) { goto do_unallocated; } - if (op3 != 2 || op3 != 3) { + if ((op3 & ~1) != 2) { goto do_unallocated; } if (s->pauth_active) {