| Message ID | 20190117185628.21862-2-crosa@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Acceptance Tests: target architecture support | expand |
On Thu, Jan 17, 2019 at 01:56:11PM -0500, Cleber Rosa wrote: > Even when the launch of QEMU succeeds, it's useful to have the command > line recorded. > > Signed-off-by: Cleber Rosa <crosa@redhat.com> Reviewed-by: Caio Carrara <ccarrara@redhat.com> > --- > scripts/qemu.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/scripts/qemu.py b/scripts/qemu.py > index 6e3b0e6771..ec3567d4e2 100644 > --- a/scripts/qemu.py > +++ b/scripts/qemu.py > @@ -312,6 +312,7 @@ class QEMUMachine(object): > self._pre_launch() > self._qemu_full_args = (self._wrapper + [self._binary] + > self._base_args() + self._args) > + LOG.debug('VM launch command: %r', ' '.join(self._qemu_full_args)) > self._popen = subprocess.Popen(self._qemu_full_args, > stdin=devnull, > stdout=self._qemu_log_file, > -- > 2.20.1 >
On 1/17/19 7:56 PM, Cleber Rosa wrote: > Even when the launch of QEMU succeeds, it's useful to have the command > line recorded. > > Signed-off-by: Cleber Rosa <crosa@redhat.com> > --- > scripts/qemu.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/scripts/qemu.py b/scripts/qemu.py > index 6e3b0e6771..ec3567d4e2 100644 > --- a/scripts/qemu.py > +++ b/scripts/qemu.py > @@ -312,6 +312,7 @@ class QEMUMachine(object): > self._pre_launch() > self._qemu_full_args = (self._wrapper + [self._binary] + > self._base_args() + self._args) > + LOG.debug('VM launch command: %r', ' '.join(self._qemu_full_args)) Useful! Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > self._popen = subprocess.Popen(self._qemu_full_args, > stdin=devnull, > stdout=self._qemu_log_file, >
Cleber Rosa <crosa@redhat.com> writes: > Even when the launch of QEMU succeeds, it's useful to have the command > line recorded. > > Signed-off-by: Cleber Rosa <crosa@redhat.com> > --- > scripts/qemu.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/scripts/qemu.py b/scripts/qemu.py > index 6e3b0e6771..ec3567d4e2 100644 > --- a/scripts/qemu.py > +++ b/scripts/qemu.py > @@ -312,6 +312,7 @@ class QEMUMachine(object): > self._pre_launch() > self._qemu_full_args = (self._wrapper + [self._binary] + > self._base_args() + self._args) > + LOG.debug('VM launch command: %r', ' '.join(self._qemu_full_args)) > self._popen = subprocess.Popen(self._qemu_full_args, > stdin=devnull, > stdout=self._qemu_log_file, Reviewed-by: Alex Bennée <alex.bennee@linaro.org> -- Alex Bennée
diff --git a/scripts/qemu.py b/scripts/qemu.py index 6e3b0e6771..ec3567d4e2 100644 --- a/scripts/qemu.py +++ b/scripts/qemu.py @@ -312,6 +312,7 @@ class QEMUMachine(object): self._pre_launch() self._qemu_full_args = (self._wrapper + [self._binary] + self._base_args() + self._args) + LOG.debug('VM launch command: %r', ' '.join(self._qemu_full_args)) self._popen = subprocess.Popen(self._qemu_full_args, stdin=devnull, stdout=self._qemu_log_file,
Even when the launch of QEMU succeeds, it's useful to have the command line recorded. Signed-off-by: Cleber Rosa <crosa@redhat.com> --- scripts/qemu.py | 1 + 1 file changed, 1 insertion(+)