| Message ID | 20190110174516.21586-6-alex.bennee@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | testing/next queue for travis and docker | expand |
On 1/10/19 6:45 PM, Alex Bennée wrote: > From: Daniel P. Berrangé <berrange@redhat.com> > > Using the "latest" tag is not a good idea because this changes what > release it points to every 6 months. Together with caching of docker > builds this can cause confusion where CI has cached & built with Fedora > N, while a developer tries to reproduce a CI problem with Fedora N + 1, > or vica-verca. So we now learned the hard way commiting "FROM x:latest" to a repository is a bad practice. > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > tests/docker/dockerfiles/fedora-i386-cross.docker | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/docker/dockerfiles/fedora-i386-cross.docker b/tests/docker/dockerfiles/fedora-i386-cross.docker > index a4fd895b07..eb8108d118 100644 > --- a/tests/docker/dockerfiles/fedora-i386-cross.docker > +++ b/tests/docker/dockerfiles/fedora-i386-cross.docker > @@ -1,4 +1,4 @@ > -FROM fedora:latest If checkpatch wasn't in Perl I'd have added a check to ban :latest. > +FROM fedora:29 > ENV PACKAGES \ > gcc \ > glib2-devel.i686 \ > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
On Thu, Jan 10, 2019 at 06:54:24PM +0100, Philippe Mathieu-Daudé wrote: > On 1/10/19 6:45 PM, Alex Bennée wrote: > > From: Daniel P. Berrangé <berrange@redhat.com> > > > > Using the "latest" tag is not a good idea because this changes what > > release it points to every 6 months. Together with caching of docker > > builds this can cause confusion where CI has cached & built with Fedora > > N, while a developer tries to reproduce a CI problem with Fedora N + 1, > > or vica-verca. > > So we now learned the hard way commiting "FROM x:latest" to a repository > is a bad practice. Unfortunately this is the second time we've had to learn it :-( commit 5b9b49d7bd3e0da13e8f6d58578443a11817f56e Author: Paolo Bonzini <pbonzini@redhat.com> Date: Fri Jan 12 12:11:43 2018 +0100 docker: change Fedora base image to fedora:27 Using "fedora:latest" makes behavior different depending on when you actually pulled the image from the docker repository. In my case, the supposedly "latest" image was a Fedora 25 download from 8 months ago, and the new "test-debug" test was failing. Use "27" to improve reproducibility and make it clear when the image is obsolete. Regards, Daniel
diff --git a/tests/docker/dockerfiles/fedora-i386-cross.docker b/tests/docker/dockerfiles/fedora-i386-cross.docker index a4fd895b07..eb8108d118 100644 --- a/tests/docker/dockerfiles/fedora-i386-cross.docker +++ b/tests/docker/dockerfiles/fedora-i386-cross.docker @@ -1,4 +1,4 @@ -FROM fedora:latest +FROM fedora:29 ENV PACKAGES \ gcc \ glib2-devel.i686 \