From patchwork Sat Dec 22 09:50:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Apfelbaum X-Patchwork-Id: 1017807 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::12; helo=lists.nongnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="pc+6Bwf3"; dkim-atps=neutral Received: from lists.nongnu.org (lists.nongnu.org [IPv6:2001:4830:134:3::12]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43MLSf0Yc9z9sP9 for ; Sat, 22 Dec 2018 20:54:41 +1100 (AEDT) Received: from localhost ([::1]:40890 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gadzT-0000Gd-Ix for incoming@patchwork.ozlabs.org; Sat, 22 Dec 2018 04:54:39 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41606) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gadvt-0006BN-9U for qemu-devel@nongnu.org; Sat, 22 Dec 2018 04:50:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gadvp-0006Lh-5r for qemu-devel@nongnu.org; Sat, 22 Dec 2018 04:50:57 -0500 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:43227) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gadvm-0006IS-Q2 for qemu-devel@nongnu.org; Sat, 22 Dec 2018 04:50:51 -0500 Received: by mail-wr1-x442.google.com with SMTP id r10so7501221wrs.10 for ; Sat, 22 Dec 2018 01:50:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4nvGW0Z3fwJM51D7eCHH6NpEw6DMydEHMqb7Z6Ln3ak=; b=pc+6Bwf3g0T4qBikt2WbyEq0mhZg+LR9qarICU90pzD7JsVjk98FBXe19Ma3XA1jye H7xxpbcPXn6QFAhW/0L8+iO3synimCRVnFfwPuXg00K4Zo68X8wcTZnK3fHmzr+2j3Fz 6zTUCr6T7BnOoL9ovW1xRO8s45DZkcRYP0xDx82wfDLe9RWdW/TzTcYmnRsSMIUFSqoA EHssbndbt6GQU9P4rYJ/GntnUNh23EGNKcEFrK8liPURozyy5Ih2Gr+Yn8eBzhGnpQKP kZXSKRySw4SeXUp0lhFRsE579p2hAsgAMrxC8wugGbxQjdLR6F8eOq1pYJ5fl6WQhYtf 2lig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4nvGW0Z3fwJM51D7eCHH6NpEw6DMydEHMqb7Z6Ln3ak=; b=oAE7isSYiDc3vPsefnbev412t4YM0lUullwlEk0+EZYB0I8tv+nsub9F4o0VB6g09r 1NCUP/W4Rjj8Vc3lsngxt8jNfVEzrziyLFn//lNHfl/Y1CcDFMiTHI7w569tu1bq6D0b X/7U9gwIS3A+7vo4pnr7pUCjqV5nl4QqxgdLsCzXZXwDh/GYXDufIhiAlD3fqcfKKWrr c0nE9PiOfSdfC5CqIw1I5NXI0gc2W1O6Cj4/vCqLDtcnsiU4JaIspTI7O5Xb1XPpOLFJ +BUZxsJzf5RUUz9oTkOjKrxISyqCgVhNnbHrK5k5OXpo0PdivPmvlASmBqtfPjoYW2Ma UVmw== X-Gm-Message-State: AJcUukfls4sNfnTsiRKg7luu97EJR+hY8puthQAZ9DWPMp7+WNyPF9fi rcNkUcb0G/KXi9Z1F9DtKbkK+Lzj X-Google-Smtp-Source: ALg8bN4jVFKqH+B/rWgnJYS/2SRsPc2nfc6PAhSxx3WQ+fxDtxO8GVMfZ4GyecrJx5+17RGs2qBIcg== X-Received: by 2002:adf:a357:: with SMTP id d23mr5922374wrb.195.1545472246970; Sat, 22 Dec 2018 01:50:46 -0800 (PST) Received: from localhost.localdomain ([176.228.155.165]) by smtp.gmail.com with ESMTPSA id s3sm9557371wmj.23.2018.12.22.01.50.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Dec 2018 01:50:46 -0800 (PST) From: Marcel Apfelbaum To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Sat, 22 Dec 2018 11:50:10 +0200 Message-Id: <20181222095036.29743-6-marcel.apfelbaum@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181222095036.29743-1-marcel.apfelbaum@gmail.com> References: <20181222095036.29743-1-marcel.apfelbaum@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::442 Subject: [Qemu-devel] [PATCH PULL 05/31] hw/rdma: Abort send-op if fail to create addr handler X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yuval.shaia@oracle.com, pjp@fedoraproject.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Yuval Shaia Function create_ah might return NULL, let's exit with an error. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum Signed-off-by: Marcel Apfelbaum --- hw/rdma/rdma_backend.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c index d7a4bbd91f..1e148398a2 100644 --- a/hw/rdma/rdma_backend.c +++ b/hw/rdma/rdma_backend.c @@ -338,6 +338,10 @@ void rdma_backend_post_send(RdmaBackendDev *backend_dev, if (qp_type == IBV_QPT_UD) { wr.wr.ud.ah = create_ah(backend_dev, qp->ibpd, backend_dev->backend_gid_idx, dgid); + if (!wr.wr.ud.ah) { + comp_handler(IBV_WC_GENERAL_ERR, VENDOR_ERR_FAIL_BACKEND, ctx); + goto out_dealloc_cqe_ctx; + } wr.wr.ud.remote_qpn = dqpn; wr.wr.ud.remote_qkey = dqkey; }